From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org, broonie@kernel.org,
Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [PATCH v2 2/2] ALSA: hda: fix to wait for RIRB & CORB DMA to set
Date: Mon, 9 May 2016 10:08:24 +0530 [thread overview]
Message-ID: <20160509043823.GW2274@localhost> (raw)
In-Reply-To: <s5h8tzksx0x.wl-tiwai@suse.de>
On Sun, May 08, 2016 at 11:45:50AM +0200, Takashi Iwai wrote:
> > +/* wait for cmd dmas till they are stopped */
> > +static void hdac_wait_for_cmd_dmas(struct hdac_bus *bus)
> > +{
> > + unsigned long timeout;
> > +
> > + timeout = jiffies + msecs_to_jiffies(100);
> > + while ((snd_hdac_chip_readb(bus, RIRBCTL) & AZX_RBCTL_DMA_EN)
> > + && time_before(jiffies, timeout))
> > + udelay(10);
> > +
> > + timeout = jiffies + msecs_to_jiffies(100);
> > + while ((snd_hdac_chip_readb(bus, CORBCTL) & AZX_CORBCTL_RUN)
> > + && time_before(jiffies, timeout))
> > + udelay(10);
>
> This will end up with doubled timeout. But it doesn't matter so much
> in practice. So I applied the patch as is.
Thanks Takashi
--
~Vinod
next prev parent reply other threads:[~2016-05-09 4:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 5:54 [PATCH v2 1/2] ALSA: hda: fix the missing ptr initialization Vinod Koul
2016-05-05 5:54 ` [PATCH v2 2/2] ALSA: hda: fix to wait for RIRB & CORB DMA to set Vinod Koul
2016-05-08 9:45 ` Takashi Iwai
2016-05-09 4:38 ` Vinod Koul [this message]
2016-05-08 9:43 ` [PATCH v2 1/2] ALSA: hda: fix the missing ptr initialization Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509043823.GW2274@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).