From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 0/5] Fix poll error returns
Date: Mon, 9 May 2016 20:49:19 +0530 [thread overview]
Message-ID: <20160509151919.GE2274@localhost> (raw)
In-Reply-To: <s5h4ma7qvi4.wl-tiwai@suse.de>
On Mon, May 09, 2016 at 02:13:55PM +0200, Takashi Iwai wrote:
> On Wed, 04 May 2016 15:59:06 +0200,
> Charles Keepax wrote:
> >
> > We return negative values from the file_operations poll callback
> > in a few places, this callback returns an unsigned int and is
> > expected to only return the poll specific flags. This series
> > fixes up these issues and makes a couple of small tidy ups to the
> > code around the edges of those functions.
> >
> > I noticed this issue whilst doing some additional testing on my
> > propagation of compressed stream error series, but I decided to
> > push these up separately as it is worth getting the fixes in
> > now and not tying them up with that patch chain which is taking
> > longer to get merged. Also I included the first patch of that
> > chain (Replace complex if statement with switch) because it is a
> > trivial tidy up and might as well get merged now as well.
>
> Patches 2, 3 and 4 miss Vinod's ack. Vinod, are you OK with them?
Yup, they look good to me so:
Acked-by: Vinod Koul <vinod.koul@intel.com>
Thanks
--
~Vinod
next prev parent reply other threads:[~2016-05-09 15:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 13:59 [PATCH 0/5] Fix poll error returns Charles Keepax
2016-05-04 13:59 ` [PATCH 1/5] ALSA: pcm: Fix poll error return codes Charles Keepax
2016-05-04 23:26 ` Takashi Sakamoto
2016-05-05 9:39 ` Clemens Ladisch
2016-05-05 11:46 ` Charles Keepax
2016-05-06 18:11 ` Takashi Sakamoto
2016-05-04 13:59 ` [PATCH 2/5] ALSA: compress: Use snd_compr_get_poll on error path Charles Keepax
2016-05-04 13:59 ` [PATCH 3/5] ALSA: compress: Remove pointless NULL check Charles Keepax
2016-05-04 13:59 ` [PATCH 4/5] ALSA: compress: Fix poll error return codes Charles Keepax
2016-05-04 13:59 ` [PATCH v6 RESEND 5/5] ALSA: compress: Replace complex if statement with switch Charles Keepax
2016-05-09 12:13 ` [PATCH 0/5] Fix poll error returns Takashi Iwai
2016-05-09 15:19 ` Vinod Koul [this message]
2016-05-09 15:36 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509151919.GE2274@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).