From: Mark Brown <broonie@kernel.org>
To: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Support Opensource <support.opensource@diasemi.com>
Subject: Re: [PATCH 2/5] ASoC: da7213: Add checking of SRM lock status before enabling DAI
Date: Tue, 10 May 2016 19:23:53 +0100 [thread overview]
Message-ID: <20160510182353.GA6019@sirena.org.uk> (raw)
In-Reply-To: <20160510182143.GD6261@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 484 bytes --]
On Tue, May 10, 2016 at 07:21:43PM +0100, Mark Brown wrote:
> On Tue, May 10, 2016 at 04:11:05PM +0100, Adam Thomson wrote:
>
> > + /* Slave mode, if SRM not enabled no need for status checks */
> > + pll_ctrl = snd_soc_read(codec, DA7213_PLL_CTRL);
> > + if (!(pll_ctrl & DA7213_PLL_SRM_EN))
> > + return 0;
>
> This isn't going to work, the driver has no volatile registers but it
> does have a cache...
Ugh, yes it does - was looking at the wrong driver there.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-05-10 18:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 15:11 [PATCH 0/5] ASoC: da7213: clocking related improvements for codec Adam Thomson
2016-05-10 15:11 ` [PATCH 1/5] ASoC: da7213: Add DAI DAPM event to control DAI clocks Adam Thomson
2016-05-10 18:49 ` Applied "ASoC: da7213: Add DAI DAPM event to control DAI clocks" to the asoc tree Mark Brown
2016-05-10 15:11 ` [PATCH 2/5] ASoC: da7213: Add checking of SRM lock status before enabling DAI Adam Thomson
2016-05-10 18:21 ` Mark Brown
2016-05-10 18:23 ` Mark Brown [this message]
2016-05-10 18:49 ` Applied "ASoC: da7213: Add checking of SRM lock status before enabling DAI" to the asoc tree Mark Brown
2016-05-10 15:11 ` [PATCH 3/5] ASoC: da7213: Default PC counter to free-running when DAI disabled Adam Thomson
2016-05-10 18:48 ` Applied "ASoC: da7213: Default PC counter to free-running when DAI disabled" to the asoc tree Mark Brown
2016-05-10 15:11 ` [PATCH 4/5] ASoC: da7213: Update PLL ranges to improve locking at frequency boundary Adam Thomson
2016-05-10 18:48 ` Applied "ASoC: da7213: Update PLL ranges to improve locking at frequency boundary" to the asoc tree Mark Brown
2016-05-10 15:11 ` [PATCH 5/5] ASoC: da7213: Allow PLL disable/bypass when using 32KHz sysclk Adam Thomson
2016-05-10 18:48 ` Applied "ASoC: da7213: Allow PLL disable/bypass when using 32KHz sysclk" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510182353.GA6019@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).