Re: [PATCH v2 1/2] ASoC: dapm: support user-defined stop condition in dai_get_connected_widgets

[Piotr Stankiewicz <piotrs@opensource.wolfsonmicro.com>]

On Fri, May 13, 2016 at 02:43:20PM +0100, Mark Brown wrote:
> On Fri, May 13, 2016 at 02:01:43PM +0100, Piotr Stankiewicz wrote:
> > On Fri, May 13, 2016 at 01:09:05PM +0100, Mark Brown wrote:
> 
> > > This seems really weird and uncomfortable.  From the naming I would
> > > expect it to be a boolean function and I'm struggling to understand when
> > > it would be useful to report multiple endpoints on a widget (edge
> > > widgets normally being single objects).  The whole counting thing is
> > > mainly a combination of debugging and an artefact of the implementation.
> > > What's the motivation here?
> 
> > I don't have a strong reason for this. My motivation here was - since I
> > am adding support for stopping an arbitrary point, it could be that
> > someone would find a use in stopping the graph walk part-way through, and
> > still reporting the number of endpoints as normal. But, if that's
> > unlikely to be of use, I'm happy to make it a boolean function.
> 
> Why would the number of endpoints at the edge of the graph ever be
> something other than 0 or 1?

Now that I think about it, indeed it does not make sense. I'll respin my
pathes with custom_stop_condition returning a bool.