From: Mark Brown <broonie@kernel.org>
To: Kai Chieh Chuang <kaichieh.chuang@mediatek.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: DPCM: skip DAPM_STREAM_STOP event to BE, if still used by other FE
Date: Fri, 3 Jun 2016 01:18:42 +0100 [thread overview]
Message-ID: <20160603001842.GY2282@sirena.org.uk> (raw)
In-Reply-To: <1464673532.31906.2.camel@mtkswgap22>
[-- Attachment #1.1: Type: text/plain, Size: 674 bytes --]
On Tue, May 31, 2016 at 01:45:32PM +0800, Kai Chieh Chuang wrote:
> + /* don't sent stop event if this BE is used by other FE */
> + if (event == SND_SOC_DAPM_STREAM_STOP &&
> + be->dpcm[dir].users >= 1) {
> + pr_warn("kc, %s(), be->dai_link->name %s skip stop event\n",
> __func__, be->dai_link->name);
> + continue;
> + }
> +
> snd_soc_dapm_stream_event(be, dir, event);
> }
If this isn't happening that seems like a bug, I'm a bit surprised
nobody else ran into it? Shouldn't the counts of stream events that
happen be symmetric (ie, we get as many stops as starts), or are we
possibly missing some from things being switched in and out or something?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-06-03 0:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 5:45 DPCM: skip DAPM_STREAM_STOP event to BE, if still used by other FE Kai Chieh Chuang
2016-06-03 0:18 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-06-05 6:58 Kai Chieh Chuang
[not found] ` <1466749294.16718.1.camel@mtkswgap22>
2016-06-29 19:04 ` Mark Brown
2016-06-29 19:08 ` Mark Brown
[not found] ` <1467599214.21156.2.camel@mtkswgap22>
2016-07-04 9:11 ` Mark Brown
2016-05-24 5:13 Chuang Eric
2016-05-24 5:06 srv_kaichieh.chaung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603001842.GY2282@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kaichieh.chuang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).