From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: patches.audio@intel.com, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda - fix whitespaces
Date: Thu, 9 Jun 2016 15:20:24 +0530 [thread overview]
Message-ID: <20160609095024.GU16910@localhost> (raw)
In-Reply-To: <s5hh9d2c1lf.wl-tiwai@suse.de>
On Thu, Jun 09, 2016 at 08:34:20AM +0200, Takashi Iwai wrote:
> On Thu, 09 Jun 2016 08:22:44 +0200,
> Vinod Koul wrote:
> >
> > Some trailing whitespaces seems to have crept in the hda_intel.c,
> > so fix them up
> >
> > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
>
> Well, this kind of "fix" doesn't improve readability but often makes
> stable backporting harder. So I'd like to skip it.
>
> This, of course, depends on the state of the code: for the code that
> is being actively rewritten, it's good to have such fixes. OTOH, for
> the longly maintained code, it's not clear whether to apply or not.
Okay I dont mind. I noticed these spaces while doing the Kabylake patch, so
thought to send :)
--
~Vinod
prev parent reply other threads:[~2016-06-09 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 6:22 [PATCH] ALSA: hda - fix whitespaces Vinod Koul
2016-06-09 6:34 ` Takashi Iwai
2016-06-09 9:50 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609095024.GU16910@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=patches.audio@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).