[PATCH] ALSA: hda - fix whitespaces

[PATCH] ALSA: hda - fix whitespaces

[Vinod Koul]

Some trailing whitespaces seems to have crept in the hda_intel.c,
so fix them up

Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/pci/hda/hda_intel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 94089fc71884..5520082ad770 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -383,8 +383,8 @@ static char *driver_short_names[] = {
 	[AZX_DRIVER_SIS] = "HDA SIS966",
 	[AZX_DRIVER_ULI] = "HDA ULI M5461",
 	[AZX_DRIVER_NVIDIA] = "HDA NVidia",
-	[AZX_DRIVER_TERA] = "HDA Teradici", 
-	[AZX_DRIVER_CTX] = "HDA Creative", 
+	[AZX_DRIVER_TERA] = "HDA Teradici",
+	[AZX_DRIVER_CTX] = "HDA Creative",
 	[AZX_DRIVER_CTHDA] = "HDA Creative",
 	[AZX_DRIVER_CMEDIA] = "HDA C-Media",
 	[AZX_DRIVER_GENERIC] = "HD-Audio Generic",
-- 
1.9.1

Re: [PATCH] ALSA: hda - fix whitespaces

[Takashi Iwai]

On Thu, 09 Jun 2016 08:22:44 +0200,
Vinod Koul wrote:
> 
> Some trailing whitespaces seems to have crept in the hda_intel.c,
> so fix them up
> 
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>

Well, this kind of "fix" doesn't improve readability but often makes
stable backporting harder.  So I'd like to skip it.

This, of course, depends on the state of the code: for the code that
is being actively rewritten, it's good to have such fixes.  OTOH, for
the longly maintained code, it's not clear whether to apply or not.


thanks,

Takashi

> ---
>  sound/pci/hda/hda_intel.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 94089fc71884..5520082ad770 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -383,8 +383,8 @@ static char *driver_short_names[] = {
>  	[AZX_DRIVER_SIS] = "HDA SIS966",
>  	[AZX_DRIVER_ULI] = "HDA ULI M5461",
>  	[AZX_DRIVER_NVIDIA] = "HDA NVidia",
> -	[AZX_DRIVER_TERA] = "HDA Teradici", 
> -	[AZX_DRIVER_CTX] = "HDA Creative", 
> +	[AZX_DRIVER_TERA] = "HDA Teradici",
> +	[AZX_DRIVER_CTX] = "HDA Creative",
>  	[AZX_DRIVER_CTHDA] = "HDA Creative",
>  	[AZX_DRIVER_CMEDIA] = "HDA C-Media",
>  	[AZX_DRIVER_GENERIC] = "HD-Audio Generic",
> -- 
> 1.9.1
> 

Re: [PATCH] ALSA: hda - fix whitespaces

[Vinod Koul]

On Thu, Jun 09, 2016 at 08:34:20AM +0200, Takashi Iwai wrote:
> On Thu, 09 Jun 2016 08:22:44 +0200,
> Vinod Koul wrote:
> > 
> > Some trailing whitespaces seems to have crept in the hda_intel.c,
> > so fix them up
> > 
> > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> 
> Well, this kind of "fix" doesn't improve readability but often makes
> stable backporting harder.  So I'd like to skip it.
> 
> This, of course, depends on the state of the code: for the code that
> is being actively rewritten, it's good to have such fixes.  OTOH, for
> the longly maintained code, it's not clear whether to apply or not.

Okay I dont mind. I noticed these spaces while doing the Kabylake patch, so
thought to send :)

-- 
~Vinod