From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Intel: Add support for PM ops in bxt-da7219_max98357a
Date: Fri, 17 Jun 2016 13:35:23 +0100 [thread overview]
Message-ID: <20160617123523.GP26099@sirena.org.uk> (raw)
In-Reply-To: <20160617121359.GH16910@localhost>
[-- Attachment #1.1: Type: text/plain, Size: 609 bytes --]
On Fri, Jun 17, 2016 at 05:44:00PM +0530, Vinod Koul wrote:
> On Fri, Jun 17, 2016 at 12:14:07PM +0100, Mark Brown wrote:
> > Just use snd_soc_resume() directly.
> Nope, that leads to warnings.
> .complete is the only callback that expects void return whereas
> snd_soc_resume like other returns int.
This is possibly an indication that you're abusing things then - this is
a very unusual interface to use as well... the patch just looks very
fishy as is, and as we were talking about in the other thread Lars
started it seems like this is bodging around something rather than
solving the right problem.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-06-17 12:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 4:33 [PATCH] ASoC: Intel: Add support for PM ops in bxt-da7219_max98357a Vinod Koul
2016-06-17 11:14 ` Mark Brown
2016-06-17 12:14 ` Vinod Koul
2016-06-17 12:35 ` Mark Brown [this message]
2016-06-20 11:47 ` Vinod Koul
2016-06-17 11:18 ` Lars-Peter Clausen
2016-06-17 12:15 ` Vinod Koul
2016-06-17 12:31 ` Mark Brown
2016-06-20 11:44 ` Vinod Koul
2016-06-20 13:26 ` Mark Brown
2016-06-20 14:02 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617123523.GP26099@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox