Re: [PATCH 0/4] ASoC: tpa6130a2: Add support for multiple instances

[Sebastian Reichel <sre@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 2284 bytes --]

Hi,

On Sat, Jun 18, 2016 at 12:40:38PM +0200, Sebastian Reichel wrote:
> On Sat, Jun 18, 2016 at 12:26:27AM -0300, Helen Koike wrote:
> > The current tpa6130a2 driver supports only a single instance.
> > This patch series add support for multiple instances by removing
> > the global variable that holds the instance. This is performed by
> > using the component API, regmap, the snd_soc_{info,put,get}_volsw
> > API and DAPM.
> 
> yay! *stroking cleanup of the driver from my todo list*
> 
> > This patch series also touches code from the Nokia RX51 which I
> > didn't tested (as I am testing the tpa6130a2 in another board, that
> > is not upstream). I would appreciate is if someone who possesses
> > the Nokia RX51 (n900) could please test the code.
> 
> I had a look at the rx51 parts and will test later/tomorrow.

Ok, here are some notes (I used the git branch you provided). First
of all kernel messages contain:

[    4.217163] ALSA: Control name 'TPA6130A2 TPA6130A2 Headphone Playback Volum' truncated to 'TPA6130A2 TPA6130A2 Headphone Playback Volu'

Next here is a amixer output diff:

root@n900:~# amixer > amixer.old (v4.7-rc [without your patches])
root@n900:~# amixer > amixer.new
root@n900:~# diff -u amixer.old amixer.new
--- amixer.old	2016-06-18 23:08:57.478027343 +0200
+++ amixer.new	2016-06-18 22:26:13.878102558 +0200
@@ -480,11 +480,12 @@
   Capabilities: pswitch pswitch-joined
   Playback channels: Mono
   Mono: Playback [off]
-Simple mixer control 'TPA6130A2 Headphone',0
-  Capabilities: pvolume pvolume-joined
+Simple mixer control 'TPA6130A2 TPA6130A2 Headphone Playback Volu',0
+  Capabilities: volume volume-joined
   Playback channels: Mono
-  Limits: Playback 0 - 42
-  Mono: Playback 0 [0%] [-59.50dB]
+  Capture channels: Mono
+  Limits: 0 - 63
+  Mono: 0 [0%]
 Simple mixer control 'b ADC HPF Cut-off',0
   Capabilities: enum
   Items: 'Disabled' '0.0045xFs' '0.0125xFs' '0.025xFs'

If I remember correctly, the reduced playback limit up to 42 is
important on N900, since hardware can be destroyed. It may have been
another control, though. Also the capture channel looks wrong.

Last but not least: Audio output doesn't work, but works on a kernel
without these changes.

-- Sebastian

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]