From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
brian.austin@cirrus.com, Paul.Handrigan@cirrus.com,
lgirdwood@gmail.com, broonie@kernel.org
Subject: Re: [PATCH] ASoC: cs53l30: Add MUTE pin control support via GPIO
Date: Tue, 21 Jun 2016 15:32:11 -0700 [thread overview]
Message-ID: <20160621223211.GA4287@Asurada-Nvidia> (raw)
In-Reply-To: <20160621213437.GA3571@rob-hp-laptop>
On Tue, Jun 21, 2016 at 04:34:37PM -0500, Rob Herring wrote:
> On Mon, Jun 20, 2016 at 06:54:44PM -0700, Nicolin Chen wrote:
> > The codec chip has a physical MUTE pin to let users control it via
> > GPIO. So this patch add a mute control support to the driver.
> >
> > Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
> > ---
> > .../devicetree/bindings/sound/cs53l30.txt | 2 ++
> > sound/soc/codecs/cs53l30.c | 30 ++++++++++++++++++++++
> > sound/soc/codecs/cs53l30.h | 1 +
> > 3 files changed, 33 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/cs53l30.txt b/Documentation/devicetree/bindings/sound/cs53l30.txt
> > index 18d6b99..6f7d3c8 100644
> > --- a/Documentation/devicetree/bindings/sound/cs53l30.txt
> > +++ b/Documentation/devicetree/bindings/sound/cs53l30.txt
> > @@ -13,6 +13,8 @@ Optional properties:
> >
> > - reset-gpios : a GPIO spec for the reset pin.
> >
> > + - mute-gpios : a GPIO spec for the MUTE pin.
>
> Please define the active state for the gpio.
The active state here is programmable and being taken care by the
driver automatically. Maybe I should have mentioned this in the
binding as well?
Thanks
Nic
prev parent reply other threads:[~2016-06-21 22:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 1:54 [PATCH] ASoC: cs53l30: Add MUTE pin control support via GPIO Nicolin Chen
[not found] ` <1466474084-6775-1-git-send-email-nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-21 21:34 ` Rob Herring
2016-06-21 22:32 ` Nicolin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621223211.GA4287@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).