From: Bob Copeland <me@bobcopeland.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: UBSAN bug in hda_generic.c
Date: Sat, 25 Jun 2016 07:52:40 -0400 [thread overview]
Message-ID: <20160625115240.GA15917@localhost> (raw)
In-Reply-To: <s5hh9chse2n.wl-tiwai@suse.de>
On Sat, Jun 25, 2016 at 01:28:00PM +0200, Takashi Iwai wrote:
> On Sat, 25 Jun 2016 13:08:02 +0200,
> Bob Copeland wrote:
> >
> > Hi,
> >
> > I have UBSAN reporting an out-of-bounds array access (see below) on my
> > machine. The following patch fixes the warning for me, but not sure if
> > that is just papering over some other bug. Thanks in advance for looking!
>
> A better check would be to put
> if (!path->depth)
> continue;
> before both path->path[0] and path->path[path->depth - 1]
> evaluations. path->depth=1 cannot exist, but path->depth=0 might be.
>
> Could you resubmit with that fix?
Sure, patch to follow in a separate mail so that patchwork can pick it up.
--
Bob Copeland %% http://bobcopeland.com/
prev parent reply other threads:[~2016-06-25 11:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-25 11:08 UBSAN bug in hda_generic.c Bob Copeland
2016-06-25 11:28 ` Takashi Iwai
2016-06-25 11:52 ` Bob Copeland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160625115240.GA15917@localhost \
--to=me@bobcopeland.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).