From: Mark Brown <broonie@kernel.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: robh@kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, b.zolnierkie@samsung.com,
inki.dae@samsung.com, Beomho Seo <beomho.seo@samsung.com>,
ideal.song@samsung.com
Subject: Re: [PATCH v2 2/6] ASoC: samsung: Add Samsung Low Power Audio Subsystem driver
Date: Fri, 1 Jul 2016 17:07:09 +0200 [thread overview]
Message-ID: <20160701150709.GT6247@sirena.org.uk> (raw)
In-Reply-To: <577553FE.6080803@samsung.com>
[-- Attachment #1.1: Type: text/plain, Size: 1150 bytes --]
On Thu, Jun 30, 2016 at 07:16:46PM +0200, Sylwester Nawrocki wrote:
> Sorry, I didn't notice this e-mail earlier. With previous Exynos versions
> the LPASS (or AudioSS) was mainly about the embedded audio DSP processor
> (at least WRT to SFRs), which was not required for boards supported in
> the mainline kernel. Since e.g. Exynos5433 the LPASS SFR region contains
> also entries related to other IP blocks, like I2S or DMAC. Even though
> functionality covered by these registers is still rather trivial, like
> SW resets and unmasking interrupts, it's essential for the whole audio
> subsystem operation. The intention was to have in future the LPASS driver
> covering any functionality provided by the embedded audio dedicated MCU.
> I'm afraid we have to handle those power sequences in central place to
> ensure proper SoC operation. I would also rather avoid adding any exynos
> quirks to the PL330 DMAC driver.
Hrm. This is sounding a bit like a combination of a power domain and
an interrupt controller, would something like that fit in perhaps?
Depends on how many of these trivial bits there are I think...
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-07-01 15:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 10:45 [PATCH v2 0/6] Sound support for Exynos5433 TM2(E) boards Sylwester Nawrocki
[not found] ` <1466678715-19962-1-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-06-23 10:45 ` [PATCH v2 1/6] ASoC: samsung: Add DT bindings documentation for LPASS Sylwester Nawrocki
2016-06-23 10:45 ` [PATCH v2 2/6] ASoC: samsung: Add Samsung Low Power Audio Subsystem driver Sylwester Nawrocki
[not found] ` <1466678715-19962-3-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-06-29 21:57 ` Mark Brown
2016-06-30 17:16 ` Sylwester Nawrocki
[not found] ` <577553FE.6080803-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-07-01 10:35 ` [alsa-devel] " Sylwester Nawrocki
2016-07-01 15:07 ` Mark Brown [this message]
2016-07-01 16:31 ` Sylwester Nawrocki
[not found] ` <57769AE5.4050407-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-07-02 8:25 ` [alsa-devel] " Mark Brown
[not found] ` <20160702082548.GF6247-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-07-04 16:16 ` Sylwester Nawrocki
[not found] ` <577A8BF7.8090900-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-07-05 14:25 ` Mark Brown
[not found] ` <20160705142524.GW6247-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-07-05 14:58 ` Sylwester Nawrocki
2016-06-23 10:45 ` [PATCH v2 3/6] ASoC: Add DT bindings documentation for max98504 amplifier Sylwester Nawrocki
[not found] ` <1466678715-19962-4-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-06-28 20:55 ` Rob Herring
2016-06-23 10:45 ` [PATCH v2 4/6] ASoC: max98504: Add max98504 speaker amplifier driver Sylwester Nawrocki
[not found] ` <1466678715-19962-5-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-06-27 16:33 ` Mark Brown
2016-06-28 17:59 ` Sylwester Nawrocki
[not found] ` <5772BB07.4000609-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-06-28 19:31 ` [alsa-devel] " Mark Brown
2016-06-23 10:45 ` [PATCH v2 5/6] ASoC: samsung: Add DT bindings documentation for TM2 sound subsystem Sylwester Nawrocki
[not found] ` <1466678715-19962-6-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-06-28 20:55 ` Rob Herring
2016-06-23 10:45 ` [PATCH v2 6/6] ASoC: samsung: Add machine driver for Exynos5433 based TM2 board Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160701150709.GT6247@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=b.zolnierkie@samsung.com \
--cc=beomho.seo@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=ideal.song@samsung.com \
--cc=inki.dae@samsung.com \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).