From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Subject: [PATCH RFC alsa-lib 4/5] pcm: Remove superfluous rmb() from PCM meter plugin
Date: Tue, 5 Jul 2016 17:20:23 +0200 [thread overview]
Message-ID: <20160705152024.20152-5-tiwai@suse.de> (raw)
In-Reply-To: <20160705152024.20152-1-tiwai@suse.de>
rmb() is still left in the code without any actual meaning there just
before the atomic operation. Let's clean it up.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
src/pcm/pcm_meter.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/pcm/pcm_meter.c b/src/pcm/pcm_meter.c
index 1b0ccb40b3dd..d71af7a683e0 100644
--- a/src/pcm/pcm_meter.c
+++ b/src/pcm/pcm_meter.c
@@ -136,7 +136,6 @@ static int snd_pcm_meter_update_scope(snd_pcm_t *pcm)
_again:
rptr = *pcm->hw.ptr;
old_rptr = meter->rptr;
- rmb();
if (atomic_read(&meter->reset)) {
reset = 1;
atomic_dec(&meter->reset);
--
2.9.0
next prev parent reply other threads:[~2016-07-05 15:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 15:20 [PATCH RFC alsa-lib 0/5] Add thread-safety to PCM API Takashi Iwai
2016-07-05 15:20 ` [PATCH RFC alsa-lib 1/5] pcm: " Takashi Iwai
2016-07-05 16:30 ` Clemens Ladisch
2016-07-05 16:36 ` Takashi Iwai
2016-07-05 15:20 ` [PATCH RFC alsa-lib 2/5] test: Add pcm-multi-thread program Takashi Iwai
2016-07-05 15:20 ` [PATCH RFC alsa-lib 3/5] Add pcm-multi-thread to .gitignore Takashi Iwai
2016-07-05 15:20 ` Takashi Iwai [this message]
2016-07-05 15:20 ` [PATCH RFC alsa-lib 5/5] pcm: Remove home brew atomic operations Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705152024.20152-5-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).