From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: [PATCH RFC alsa-lib 4/5] pcm: Remove superfluous rmb() from PCM meter plugin Date: Tue, 5 Jul 2016 17:20:23 +0200 Message-ID: <20160705152024.20152-5-tiwai@suse.de> References: <20160705152024.20152-1-tiwai@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 6149F2666B3 for ; Tue, 5 Jul 2016 17:20:28 +0200 (CEST) Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8FBA7AC35 for ; Tue, 5 Jul 2016 15:20:27 +0000 (UTC) In-Reply-To: <20160705152024.20152-1-tiwai@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org rmb() is still left in the code without any actual meaning there just before the atomic operation. Let's clean it up. Signed-off-by: Takashi Iwai --- src/pcm/pcm_meter.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/pcm/pcm_meter.c b/src/pcm/pcm_meter.c index 1b0ccb40b3dd..d71af7a683e0 100644 --- a/src/pcm/pcm_meter.c +++ b/src/pcm/pcm_meter.c @@ -136,7 +136,6 @@ static int snd_pcm_meter_update_scope(snd_pcm_t *pcm) _again: rptr = *pcm->hw.ptr; old_rptr = meter->rptr; - rmb(); if (atomic_read(&meter->reset)) { reset = 1; atomic_dec(&meter->reset); -- 2.9.0