From: Kenneth Westfield <kwestfie@codeaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: alsa-devel@alsa-project.org,
Banajit Goswami <bgoswami@codeaurora.org>,
linux-kernel@vger.kernel.org, Patrick Lai <plai@codeaurora.org>,
Takashi Iwai <tiwai@suse.com>,
kwestfie@codeaurora.org, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v3 2/2] sound: lpass-platform: Move dma channel allocation to pcmops
Date: Tue, 5 Jul 2016 15:23:41 -0700 [thread overview]
Message-ID: <20160705222341.GA14340@kwestfie-linux.qualcomm.com> (raw)
In-Reply-To: <1467624109-24230-2-git-send-email-srinivas.kandagatla@linaro.org>
On Mon, Jul 04, 2016 at 10:21:49AM +0100, Srinivas Kandagatla wrote:
> Move dma channel allocations to pcmops open and close functions. Reason
> to do this is that, lpass_platform_pcm_free() accesses snd_soc_pcm_runtime
> via substream->private data, However By this time runtimes are already
> freed as part of soc_cleanup_card_resources() sequence.
>
> This patch moves the channel allocations/deallocations to pcmops open()
> and close() respectively, where the code has valid snd_soc_pcm_runtime.
>
> Without this patch unloading lpass sound card module would result in below
> crash:
snip...
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
LGTM.
Acked-by: Kenneth Westfield <kwestfie@codeaurora.org>
--
Kenneth Westfield
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2016-07-05 22:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 9:21 [PATCH v3 1/2] sound: lpass-cpu: add module licence and description Srinivas Kandagatla
2016-07-04 9:21 ` [PATCH v3 2/2] sound: lpass-platform: Move dma channel allocation to pcmops Srinivas Kandagatla
2016-07-05 22:23 ` Kenneth Westfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705222341.GA14340@kwestfie-linux.qualcomm.com \
--to=kwestfie@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).