From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, patches.audio@intel.com,
Hardik T Shah <hardik.t.shah@intel.com>,
Guneshwor Singh <guneshwor.o.singh@intel.com>,
liam.r.girdwood@linux.intel.com, broonie@kernel.org,
kbuild-all@01.org
Subject: Re: [PATCH 2/3] ALSA - hda: Add support for link audio time reporting
Date: Fri, 15 Jul 2016 11:09:10 +0530 [thread overview]
Message-ID: <20160715053910.GN9681@localhost> (raw)
In-Reply-To: <s5heg6vcwf9.wl-tiwai@suse.de>
On Fri, Jul 15, 2016 at 07:17:14AM +0200, Takashi Iwai wrote:
> On Fri, 15 Jul 2016 07:19:06 +0200,
> Vinod Koul wrote:
> > > > > >> sound/pci/hda/hda_controller.c:30:21: fatal error: asm/tsc.h: No such file or directory
> > > > > compilation terminated.
> > > >
> > > > Okay i think I need to move this bit into the intel code.
> > > >
> > > > Takashi, I didnt see any X86 depends on SND_HDA_INTEL. I think we should add
> > > > this now. Are you okay with that?
> > >
> > > Better to have an explicit ifdef CONFIG_X86 around it. It's not only
> > > for x86.
> >
> > Need it around the whole of the timestamp code as well then..
>
> Yes. But why TSC is mandatory? There is no explanation in your
> patch.
HW reports ART values and we need to convert these to TSC.
The callflow is that the azx_get_crosststamp is called which invokes
get_device_system_crosststamp() and calls azx_get_sync_time callback.
So dependency is around convert_art_to_tsc() which is x86 API.
Thanks
--
~Vinod
next prev parent reply other threads:[~2016-07-15 5:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 10:13 [PATCH 0/3] ALSA - hda: Add support for link audio time reporting Vinod Koul
2016-07-11 10:13 ` [PATCH 1/3] ALSA - hda: Add support for GTS capability Vinod Koul
2016-07-11 10:22 ` Takashi Iwai
2016-07-11 14:07 ` Vinod Koul
2016-07-11 14:06 ` Takashi Iwai
2016-07-11 14:22 ` Vinod Koul
2016-07-11 14:17 ` Takashi Iwai
2016-07-11 10:13 ` [PATCH 2/3] ALSA - hda: Add support for link audio time reporting Vinod Koul
2016-07-11 10:32 ` Takashi Iwai
2016-07-11 14:11 ` Vinod Koul
[not found] ` <201607111916.R5HdrB76%fengguang.wu@intel.com>
2016-07-15 4:37 ` Vinod Koul
2016-07-15 5:00 ` Takashi Iwai
2016-07-15 5:19 ` Vinod Koul
2016-07-15 5:17 ` Takashi Iwai
2016-07-15 5:39 ` Vinod Koul [this message]
2016-07-15 5:39 ` Takashi Iwai
2016-07-15 5:50 ` Vinod Koul
2016-07-15 5:56 ` Takashi Iwai
2016-07-11 10:13 ` [PATCH 3/3] ALSA - hda: Fix timestamping documentation Vinod Koul
2016-07-11 10:46 ` Takashi Iwai
2016-07-11 14:12 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715053910.GN9681@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=guneshwor.o.singh@intel.com \
--cc=hardik.t.shah@intel.com \
--cc=kbuild-all@01.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox