alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: broonie@kernel.org
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: dapm: Add a dummy snd_pcm_runtime to avoid NULL pointer access
Date: Tue, 26 Jul 2016 14:24:12 -0700	[thread overview]
Message-ID: <20160726212411.GA663@Asurada-Nvidia> (raw)
In-Reply-To: <1469561320-31853-1-git-send-email-nicoleotsuka@gmail.com>

On Tue, Jul 26, 2016 at 12:28:40PM -0700, Nicolin Chen wrote:
> diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
> index 8698c26..eed15ca 100644
> --- a/sound/soc/soc-dapm.c
> +++ b/sound/soc/soc-dapm.c
> @@ -3493,6 +3493,7 @@ static int snd_soc_dai_link_event(struct snd_soc_dapm_widget *w,
>  	const struct snd_soc_pcm_stream *config = w->params + w->params_select;
>  	struct snd_pcm_substream substream;
>  	struct snd_pcm_hw_params *params = NULL;
> +	struct snd_pcm_runtime runtime;

Got a warning from test robot:

sound/soc/soc-dapm.c: In function 'snd_soc_dai_link_event':
sound/soc/soc-dapm.c:3614:1: warning: the frame size of 1304 bytes is larger
					than 1024 bytes [-Wframe-larger-than=]

Kzalloc() might be a better solution here.

Will send a v2. So please ignore this one.

Thanks
Nicolin

      reply	other threads:[~2016-07-26 21:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-26 19:28 [PATCH] ASoC: dapm: Add a dummy snd_pcm_runtime to avoid NULL pointer access Nicolin Chen
2016-07-26 21:24 ` Nicolin Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160726212411.GA663@Asurada-Nvidia \
    --to=nicoleotsuka@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).