From: Mark Brown <broonie@kernel.org>
To: John Hsu <KCHSU0@nuvoton.com>
Cc: WTLI@nuvoton.com, YHCHuang@nuvoton.com,
alsa-devel@alsa-project.org, CTLIN0@nuvoton.com,
lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: nau8810: Add driver for Nuvoton codec chip NAU88C10
Date: Thu, 18 Aug 2016 19:24:39 +0100 [thread overview]
Message-ID: <20160818182439.GT9347@sirena.org.uk> (raw)
In-Reply-To: <57B5098C.7020102@nuvoton.com>
[-- Attachment #1.1: Type: text/plain, Size: 683 bytes --]
On Thu, Aug 18, 2016 at 09:04:12AM +0800, John Hsu wrote:
> On 8/17/2016 5:42 PM, Mark Brown wrote:
> > The whole point with raw read is that it isn't reformatting the value.
> I post the partial function. The format_val is not valid for our
> codec driver and we can't use the regmap_raw_read(). It's the reason
> that we need to make the function like regmap_raw_read().
Hrm, and you can't just make raw read work because other users are
relying on the native endianness for single reads so bulk_read() then
for the actual I/O? At a bare minimum you need to provide comments in
the code explaining what's going on, at the minute it looks like
something that needs cleaning up.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-08-18 18:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 9:02 [PATCH] ASoC: nau8810: Add driver for Nuvoton codec chip NAU88C10 John Hsu
2016-08-15 14:06 ` Mark Brown
2016-08-16 3:57 ` John Hsu
2016-08-16 10:38 ` Mark Brown
2016-08-17 0:34 ` John Hsu
2016-08-17 9:42 ` Mark Brown
2016-08-18 1:04 ` John Hsu
2016-08-18 18:24 ` Mark Brown [this message]
2016-08-19 2:51 ` John Hsu
-- strict thread matches above, loose matches on Subject: below --
2016-08-19 9:24 John Hsu
2016-06-17 8:40 John Hsu
2016-06-27 17:15 ` Mark Brown
2016-07-01 3:34 ` John Hsu
2016-07-01 10:04 ` Mark Brown
2016-07-04 3:34 ` John Hsu
2016-08-05 12:08 ` Mark Brown
2016-08-08 2:27 ` John Hsu
2016-08-08 15:18 ` Mark Brown
2016-08-09 2:09 ` John Hsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160818182439.GT9347@sirena.org.uk \
--to=broonie@kernel.org \
--cc=CTLIN0@nuvoton.com \
--cc=KCHSU0@nuvoton.com \
--cc=WTLI@nuvoton.com \
--cc=YHCHuang@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).