From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH 1/2] ALSA: compress: Use memdup_user() rather than duplicating its implementation Date: Mon, 22 Aug 2016 10:31:17 +0530 Message-ID: <20160822050117.GC2890@localhost> References: <566ABCD9.1060404@users.sourceforge.net> <7233eb00-a941-4935-dce2-7cb907272d41@users.sourceforge.net> <375fcd8c-ebb5-5f63-f094-347559c5b9c1@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <375fcd8c-ebb5-5f63-f094-347559c5b9c1@users.sourceforge.net> Sender: kernel-janitors-owner@vger.kernel.org To: SF Markus Elfring Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: alsa-devel@alsa-project.org On Sun, Aug 21, 2016 at 09:43:22PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 21 Aug 2016 21:02:06 +0200 > > Reuse existing functionality from memdup_user() instead of keeping > duplicate source code. > > This issue was detected by using the Coccinelle software. It usually helps to have Coccinelle script in changelog. But nevertheless Acked-by: Vinod Koul > > Signed-off-by: Markus Elfring > --- > sound/core/compress_offload.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c > index 2c49848..583d407 100644 > --- a/sound/core/compress_offload.c > +++ b/sound/core/compress_offload.c > @@ -553,13 +553,9 @@ snd_compr_set_params(struct snd_compr_stream *stream, unsigned long arg) > * we should allow parameter change only when stream has been > * opened not in other cases > */ > - params = kmalloc(sizeof(*params), GFP_KERNEL); > - if (!params) > - return -ENOMEM; > - if (copy_from_user(params, (void __user *)arg, sizeof(*params))) { > - retval = -EFAULT; > - goto out; > - } > + params = memdup_user((void __user *)arg, sizeof(*params)); > + if (IS_ERR(params)) > + return PTR_ERR(params); > > retval = snd_compress_check_input(params); > if (retval) > -- > 2.9.3 > -- ~Vinod