Re: [alsa-devel] [PATCH 2/2] ALSA: firewire-tascam: accessing to user space outside spinlock

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2329 bytes --]

Hi Takashi,

[auto build test WARNING on sound/for-next]
[also build test WARNING on v4.8-rc3 next-20160825]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:    https://github.com/0day-ci/linux/commits/Takashi-Sakamoto/ALSA-fireworks-accessing-to-user-space-outside-spinlock/20160827-045250
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: tile-allyesconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 4.6.2
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=tile 

All warnings (new ones prefixed by >>):

   sound/firewire/tascam/tascam-hwdep.c: In function 'hwdep_read':
>> sound/firewire/tascam/tascam-hwdep.c:24:8: warning: missing braces around initializer [-Wmissing-braces]
   sound/firewire/tascam/tascam-hwdep.c:24:8: warning: (near initialization for 'event.common') [-Wmissing-braces]

vim +24 sound/firewire/tascam/tascam-hwdep.c

     8	
     9	/*
    10	 * This codes give three functionality.
    11	 *
    12	 * 1.get firewire node information
    13	 * 2.get notification about starting/stopping stream
    14	 * 3.lock/unlock stream
    15	 */
    16	
    17	#include "tascam.h"
    18	
    19	static long hwdep_read(struct snd_hwdep *hwdep, char __user *buf, long count,
    20			       loff_t *offset)
    21	{
    22		struct snd_tscm *tscm = hwdep->private_data;
    23		DEFINE_WAIT(wait);
  > 24		union snd_firewire_event event = {0};
    25	
    26		spin_lock_irq(&tscm->lock);
    27	
    28		while (!tscm->dev_lock_changed) {
    29			prepare_to_wait(&tscm->hwdep_wait, &wait, TASK_INTERRUPTIBLE);
    30			spin_unlock_irq(&tscm->lock);
    31			schedule();
    32			finish_wait(&tscm->hwdep_wait, &wait);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 45493 bytes --]