alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Xavi Drudis Ferran <xdrudis@tinet.cat>
To: Timur Tabi <timur@tabi.org>,
	Nicolin Chen <nicoleotsuka@gmail.com>,
	Xiubo Li <Xiubo.Lee@gmail.com>,
	Shengjiu Wang <shengjiu.wang@freescale.com>
Cc: alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org
Subject: Setting some clocks back to DUMMY fixes spdif output on imx6q wandboard rev B1
Date: Sun, 28 Aug 2016 18:00:55 +0200	[thread overview]
Message-ID: <20160828160055.GA2122@begut> (raw)

[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]

Hello. 

Sorry for my unfamiliarity with the kernel community. I'm afraid I'll
be getting the procedure wrong...

I was using linux-libre-3.19 (implies no working sdma) with a
wandboard quad (Freescale imx6q). Spidf output worked fine.

When I upgraded to linux-libre-4.7 spdif output was supressed without
any error (precisely, with the same errors about sdma that 3.19 gave).

I saw someone else reporting the same elsewhere with linux-4.4
https://forum.digikey.com/thread/34240
(but I don't have a login there) 

This patch fixes it for me and sound works again on spdif. 

But I don't know if it can break (or fix?) something for some other
boards or kernels or cases... I hardly know what I'm doing.

The commits that might have caused the problem for me might be 

commit 833f2cbf7091099baee28136dc68678e974c0ac5
Author: Shengjiu Wang <shengjiu.wang@freescale.com>
Date:   Sat Oct 10 18:15:07 2015 +0800

    ARM: dts: imx6: change the core clock of spdif
    
    The correct core clock of spdif is SPDIF_GCLK, which is added to
    clock tree. So the dts also need to be updated.
    
    Signed-off-by: Shengjiu Wang <shengjiu.wang@freescale.com>
    Signed-off-by: Shawn Guo <shawnguo@kernel.org>

(the commit changed more clocks than SPDIF_GCLK) 

It might have to do with vendor commit 

http://git.freescale.com/git/cgit.cgi/imx/linux-2.6-imx.git/commit/arch/arm/boot/dts/imx6qdl.dtsi?h=imx_4.1.15_1.0.0_ga&id=dd7ebdf5bf0458e08f0be62fd49bc6f1ca9b2f25

The issue is fixed for me with this patch but I'm not sure what's the
best way to help fix any issue someone else may have or what other
info or test you might need. Any guidance welcome. 

Thank you for linux. 

[-- Attachment #2: wandboard-quad-recover-spdif-output.diff --]
[-- Type: text/x-diff, Size: 829 bytes --]

--- linux-4.7-no-spdif-out/arch/arm/boot/dts/imx6qdl.dtsi	2016-07-25 00:19:43.000000000 +0200
+++ linux-4.7/arch/arm/boot/dts/imx6qdl.dtsi	2016-08-28 17:59:14.276774409 +0200
@@ -240,9 +240,9 @@
 					       <&sdma 15 18 0>;
 					dma-names = "rx", "tx";
 					clocks = <&clks IMX6QDL_CLK_SPDIF_GCLK>, <&clks IMX6QDL_CLK_OSC>,
-						 <&clks IMX6QDL_CLK_SPDIF>, <&clks IMX6QDL_CLK_ASRC>,
-						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_ESAI_EXTAL>,
-						 <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_MLB>,
+						 <&clks IMX6QDL_CLK_SPDIF>, <&clks IMX6QDL_CLK_DUMMY>,
+						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_DUMMY>,
+						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_DUMMY>,
 						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_SPBA>;
 					clock-names = "core",  "rxtx0",
 						      "rxtx1", "rxtx2",

[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2016-08-29 17:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-28 16:00 Xavi Drudis Ferran [this message]
2016-08-29 19:28 ` Setting some clocks back to DUMMY fixes spdif output on imx6q wandboard rev B1 Nicolin Chen
2016-08-29 19:54   ` Xavi Drudis Ferran
2016-08-30 11:14     ` Xavi Drudis Ferran
2016-08-31  4:21       ` Nicolin Chen
2016-08-31  9:10         ` Xavi Drudis Ferran
2016-08-31 13:11           ` [alsa-devel] " Fabio Estevam
2016-08-31 13:30             ` Fabio Estevam
2016-08-31 13:47               ` Xavi Drudis Ferran
2016-08-31 14:02                 ` Fabio Estevam
2016-08-31 13:49             ` Xavi Drudis Ferran
2016-08-31 17:49               ` Xavi Drudis Ferran
2016-08-31 18:02                 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160828160055.GA2122@begut \
    --to=xdrudis@tinet.cat \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=shengjiu.wang@freescale.com \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).