From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: patches.audio@intel.com, Vinod Koul <vinod.koul@intel.com>,
alsa-devel@alsa-project.org, broonie@kernel.org,
lgirdwood@gmail.com
Subject: Re: [PATCH 01/12] ALSA: hdac: Add codec helper library
Date: Mon, 29 Aug 2016 18:17:33 +0530 [thread overview]
Message-ID: <20160829124714.GA28002@subhransu-desktop> (raw)
In-Reply-To: <s5hr398t1al.wl-tiwai@suse.de>
On Mon, Aug 29, 2016 at 10:41:22AM +0200, Takashi Iwai wrote:
> On Mon, 29 Aug 2016 08:23:15 +0200,
> Subhransu S. Prusty wrote:
> >
> > Add hdac helpers to enumerate the HDA widgets and fill connection
> > lists for each.
> >
> > Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
> > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> > ---
> > include/sound/hdaudio.h | 1 +
> > sound/hda/ext/Makefile | 3 +-
> > sound/hda/ext/hdac_codec.c | 182 +++++++++++++++++++++++++++++++++++++++++++++
> > sound/hda/ext/hdac_codec.h | 53 +++++++++++++
> > 4 files changed, 238 insertions(+), 1 deletion(-)
> > create mode 100644 sound/hda/ext/hdac_codec.c
> > create mode 100644 sound/hda/ext/hdac_codec.h
> >
> > diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
> > index 93e63c5..79502dc 100644
> > --- a/include/sound/hdaudio.h
> > +++ b/include/sound/hdaudio.h
> > @@ -71,6 +71,7 @@ struct hdac_device {
> > unsigned int flags, unsigned int *res);
> >
> > /* widgets */
> > + struct list_head widget_list;
> > unsigned int num_nodes;
> > hda_nid_t start_nid, end_nid;
>
> Any reason to add this to hdac_device although it's used only by
> hda/ext?
Hi Takashi,
Added this in the hdac_device, as this looked to be the more suitable data
structure for the widget_list and is more specific to the hdac device.
Regards,
Subhransu
>
>
> thanks,
>
> Takashi
--
next prev parent reply other threads:[~2016-08-29 17:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 6:23 [PATCH 00/12] ASoC: hdac: Add hdac generic driver Subhransu S. Prusty
2016-08-29 6:23 ` [PATCH 01/12] ALSA: hdac: Add codec helper library Subhransu S. Prusty
2016-08-29 8:41 ` Takashi Iwai
2016-08-29 12:47 ` Subhransu S. Prusty [this message]
2016-08-29 12:55 ` Takashi Iwai
2016-08-29 13:17 ` Subhransu S. Prusty
2016-08-29 13:28 ` Takashi Iwai
2016-08-29 13:33 ` Subhransu S. Prusty
2016-08-29 13:43 ` Takashi Iwai
2016-08-30 7:46 ` Subhransu S. Prusty
2016-08-29 6:23 ` [PATCH 02/12] ALSA: hda - Add macro to test pin widget's input capability Subhransu S. Prusty
2016-08-29 8:42 ` Takashi Iwai
2016-08-29 13:01 ` Subhransu S. Prusty
2016-08-29 6:23 ` [PATCH 03/12] ASoC: hdac: Add a generic hdac driver framework Subhransu S. Prusty
2016-08-29 6:23 ` [PATCH 04/12] ASoC: hdac: Create DAPM model for HDA widgets Subhransu S. Prusty
2016-08-29 6:23 ` [PATCH 05/12] ALSA: hdac: Move 'to_hda_ext_device' helper to core Subhransu S. Prusty
2016-08-29 8:44 ` Takashi Iwai
2016-08-29 13:06 ` Subhransu S. Prusty
2016-08-29 13:21 ` Takashi Iwai
2016-08-29 13:20 ` Subhransu S. Prusty
2016-08-29 6:23 ` [PATCH 06/12] ASoC: hdac_hdmi: use get_edev helper from core Subhransu S. Prusty
2016-08-29 6:23 ` [PATCH 07/12] ASoC: hdac: Build DAPM graph by querying through widget connection list Subhransu S. Prusty
2016-08-29 6:23 ` [PATCH 08/12] ASoC: hdac: Register widget event handlers Subhransu S. Prusty
2016-08-29 6:23 ` [PATCH 09/12] ALSA: hda - macro to get default config device of pin widgets Subhransu S. Prusty
2016-08-29 6:23 ` [PATCH 10/12] ASoC: hdac: Export API to create machine controls Subhransu S. Prusty
2016-08-29 6:23 ` [PATCH 11/12] ALSA: hdac: Implement a match function Subhransu S. Prusty
2016-08-29 6:23 ` [PATCH 12/12] ASoC: hdac: Add coefficient init callback for RT286 Subhransu S. Prusty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829124714.GA28002@subhransu-desktop \
--to=subhransu.s.prusty@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches.audio@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).