From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: alsa-devel@alsa-project.org, broonie@linaro.org,
Takashi Iwai <tiwai@suse.de>,
omair.m.abdullah@intel.com, Vinod Koul <vinod.koul@intel.com>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>
Subject: Re: [PATCH 1/4] ALSA: control: return payload length for TLV operation
Date: Wed, 31 Aug 2016 13:19:34 +0100 [thread overview]
Message-ID: <20160831121934.GB21682@localhost.localdomain> (raw)
In-Reply-To: <e95db80c-682d-b186-ea9e-a4a8a5501329@ladisch.de>
On Wed, Aug 31, 2016 at 01:54:37PM +0200, Clemens Ladisch wrote:
> Takashi Iwai wrote:
> > TLV has never been and (will never be) an API to handle a
> > generic binary stream.
>
> It would be possible to define something like SNDRV_CTL_TLVT_HWDEP_BLOB
> or _COEFFICIENTS, or to reserve a range of TLVT values for driver-
> defined types. (But we cannot change soc-wm-adsp to support only proper
> TLV data, because this would introduce a regression.)
>
It's worth pointing out there are more users than just us, the
Intel Skylake stuff being I guess the most important user.
>
> Anyway, the separate length value could be useful only for drivers (like
> soc-wm-adsp) that use a binary stream where TLV data should have been
> used. But the software that writes these coefficients to the WM ADSP
> driver is very hardware specific anyway, and it presumably already works
> without knowing the returned length value. So there is no case where
> this patchset _actually_ improves the interface.
>
The software that writes these coefficients to wm_adsp is
not hardware specific at all its just regular amixer and
tinymix. These TLV controls are just like any other ALSA control,
normal ALSA controls don't return the length that was written
because the control is a certain size and the write either
succeeds or fails, the same is true here.
Thanks,
Charles
next prev parent reply other threads:[~2016-08-31 12:19 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 23:44 [RFC][PATCH 0/4] ALSA: control: return payload length of TLV operation Takashi Sakamoto
2016-08-29 23:44 ` [PATCH 1/4] ALSA: control: return payload length for " Takashi Sakamoto
2016-08-30 5:29 ` Takashi Iwai
2016-08-30 6:19 ` Takashi Sakamoto
2016-08-30 6:59 ` Takashi Iwai
2016-08-30 7:13 ` Takashi Sakamoto
2016-08-30 7:39 ` Takashi Iwai
2016-08-30 7:05 ` Clemens Ladisch
2016-08-30 7:09 ` Takashi Sakamoto
2016-08-30 8:04 ` Clemens Ladisch
2016-08-30 12:22 ` Takashi Sakamoto
2016-08-30 14:51 ` Vinod Koul
2016-08-30 22:04 ` Takashi Sakamoto
2016-08-31 4:20 ` Vinod Koul
2016-08-31 4:30 ` Takashi Sakamoto
2016-08-31 9:05 ` Charles Keepax
2016-08-31 9:40 ` Takashi Iwai
2016-08-31 11:54 ` Clemens Ladisch
2016-08-31 12:08 ` Takashi Iwai
2016-08-31 15:26 ` Takashi Sakamoto
2016-08-31 15:40 ` Takashi Iwai
2016-09-02 11:30 ` Takashi Sakamoto
2016-09-02 13:09 ` Takashi Iwai
2016-09-02 14:50 ` Takashi Sakamoto
2016-09-02 15:19 ` Takashi Iwai
2016-09-02 16:26 ` Takashi Iwai
2016-09-03 11:38 ` Charles Keepax
2016-09-04 11:07 ` Takashi Sakamoto
2016-09-04 20:45 ` Takashi Iwai
2016-09-06 3:30 ` Takashi Sakamoto
2016-09-12 12:37 ` Charles Keepax
2016-09-12 15:25 ` Vinod Koul
2016-09-12 15:28 ` Takashi Iwai
2016-09-12 16:03 ` Charles Keepax
2016-09-12 16:28 ` Takashi Iwai
2016-09-13 8:39 ` Charles Keepax
2016-08-31 12:19 ` Charles Keepax [this message]
2016-08-31 13:24 ` Clemens Ladisch
2016-08-31 14:18 ` Charles Keepax
2016-08-31 16:05 ` Vinod Koul
2016-09-02 11:18 ` Takashi Sakamoto
2016-09-02 16:05 ` Takashi Iwai
2016-09-03 3:53 ` Takashi Sakamoto
2016-09-03 11:32 ` Charles Keepax
2016-08-29 23:44 ` [PATCH 2/4] ALSA: control: delegate checking the length of data payload to each drivers Takashi Sakamoto
2016-08-30 15:46 ` Vinod Koul
2016-08-29 23:44 ` [PATCH 3/4] ALSA: control: add kerneldoc for snd_kcontrol_tlv_rw_t Takashi Sakamoto
2016-08-29 23:44 ` [PATCH 4/4] ALSA: control: bump up protocol version to 2.0.8 Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831121934.GB21682@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@linaro.org \
--cc=clemens@ladisch.de \
--cc=o-takashi@sakamocchi.jp \
--cc=omair.m.abdullah@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox