From: Tejun Heo <tj@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: tlv320dac33: Remove deprecated create_singlethread_workqueue
Date: Wed, 31 Aug 2016 17:17:45 -0400 [thread overview]
Message-ID: <20160831211745.GC12660@htj.duckdns.org> (raw)
In-Reply-To: <88b9a137-b934-f928-535f-719cfbc9bff3@ti.com>
Hello, Peter.
On Wed, Aug 31, 2016 at 10:10:47PM +0300, Peter Ujfalusi wrote:
> > What kind of time frame are we talking about? If it really needs high
> > priority, the right thing to do would be using a WQ_HIGHPRI workqueue.
>
> In order to be tune the performance and power saving during audio playback
> lower is better, but consistency matters more to be able have stable system.
> I have some latency compensation in the code so it could tolerate some drift,
> but big spikes can cause the codec to go underflow and we can not recover from
> that w/o hard reset of the codec.
Gees, that's a brutal failure mode.
> I do believe that Linux got much better over the years since I wrote the dac33
> driver, so I'm fine with the move to system_wq. The most problematic mode (I
> think it was MODE7LP or smthing) is not upstream so this change should not
> break audio on the n9/n950.
Thanks for the explanation!
--
tejun
prev parent reply other threads:[~2016-08-31 21:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 18:27 [PATCH] ASoC: tlv320dac33: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar
2016-08-31 11:56 ` [alsa-devel] " Peter Ujfalusi
2016-08-31 14:44 ` Tejun Heo
2016-08-31 19:10 ` Peter Ujfalusi
2016-08-31 21:17 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831211745.GC12660@htj.duckdns.org \
--to=tj@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bhaktipriya96@gmail.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).