From: Danny Milosavljevic <dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
To: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>,
Takashi Iwai <tiwai-IBi9RG/b67k@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: Re: [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i
Date: Wed, 31 Aug 2016 22:14:02 +0200 [thread overview]
Message-ID: <20160831221402.670ab832@scratchpost.org> (raw)
In-Reply-To: <20160831174623.GA20462@lukather>
Hi Maxime,
On Wed, 31 Aug 2016 19:46:23 +0200
Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> > -#define SUN4I_CODEC_AC_SYS_VERI (0x38)
> > -#define SUN4I_CODEC_AC_MIC_PHONE_CAL (0x3c)
> > +
> > +#define SUN7I_CODEC_AC_DAC_CAL (0x38)
> > +#define SUN7I_CODEC_AC_MIC_PHONE_CAL (0x3c)
>
> That will need at least some mention in the commit log.
Hm? It's now called like it is called in the user manual.
Also, the macro SUN4I_CODEC_AC_SYS_VERI was unused before anyway.
What should I write in the commit log?
> It would be better to add a structure assiocated to the data field of
> of_device_id. That way, you'll also be able to have any quirks without
> adding more checks (such as a different regmap config, like Chen-Yu
> suggested).
Yeah, I did that now; seems to work.
Cheers,
Danny
next prev parent reply other threads:[~2016-08-31 20:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 5:44 [PATCH v9 0/2] sun4i-codec: Add Line-In, FM-In, Mic 2, Capture Source, Differential Line-In Danny Milosavljevic
[not found] ` <20160830054403.7878-1-dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2016-08-30 5:44 ` [PATCH v9 1/2] ASoC: sun4i-codec: Distinguish sun4i from sun7i Danny Milosavljevic
[not found] ` <20160830054403.7878-2-dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2016-08-31 3:22 ` Chen-Yu Tsai
2016-08-31 17:46 ` Maxime Ripard
2016-08-31 20:14 ` Danny Milosavljevic [this message]
[not found] ` <20160831221402.670ab832-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2016-09-01 16:45 ` Maxime Ripard
2016-08-30 5:44 ` [PATCH v9 2/2] Add mixer controls: Line-In, FM-In, Mic 2, Capture Source, Differential Line-In Danny Milosavljevic
[not found] ` <20160830054403.7878-3-dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2016-08-31 6:24 ` Chen-Yu Tsai
[not found] ` <CAGb2v64zA3iSOe7ku=pF0RhJkvErxt_tbPWG4H8D6r5UEUJAMQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-31 7:17 ` Danny Milosavljevic
2016-08-31 7:46 ` Chen-Yu Tsai
2016-08-31 7:40 ` Danny Milosavljevic
2016-08-31 7:43 ` [linux-sunxi] " Chen-Yu Tsai
[not found] ` <CAGb2v67YGiZEzBezub5HcEBZ5689uF1yQYj2xJkbVdHyEpOm5Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-31 7:49 ` Danny Milosavljevic
[not found] ` <20160831094959.2e5e6ae7-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2016-08-31 7:55 ` Chen-Yu Tsai
2016-09-01 10:56 ` Danny Milosavljevic
2016-09-01 13:25 ` [linux-sunxi] " Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831221402.670ab832@scratchpost.org \
--to=dannym-bxpqe3t81xxwrsdmlxbzog@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=tiwai-IBi9RG/b67k@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).