[PATCH] ASoC: sgtl5000: add headphone and LINEOUT mute controls

[PATCH] ASoC: sgtl5000: add headphone and LINEOUT mute controls

[Richard Leitner]

These controls mute/unmute the LINEOUT and headphone outputs of SGTL5000
using its CHIP_ANA_CTRL register.

Signed-off-by: Richard Leitner <dev@g0hl1n.net>
---
 sound/soc/codecs/sgtl5000.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index 527b759..a6af65d 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -411,6 +411,8 @@ static const struct snd_kcontrol_new sgtl5000_snd_controls[] = {
 			0, 8,
 			0x7f, 1,
 			headphone_volume),
+	SOC_SINGLE("Headphone Playback Switch", SGTL5000_CHIP_ANA_CTRL,
+			4, 1, 0),
 	SOC_SINGLE("Headphone Playback ZC Switch", SGTL5000_CHIP_ANA_CTRL,
 			5, 1, 0),
 
@@ -423,6 +425,7 @@ static const struct snd_kcontrol_new sgtl5000_snd_controls[] = {
 			SGTL5000_LINE_OUT_VOL_RIGHT_SHIFT,
 			0x1f, 1,
 			lineout_volume),
+	SOC_SINGLE("Lineout Playback Switch", SGTL5000_CHIP_ANA_CTRL, 8, 1, 0),
 };
 
 /* mute the codec used by alsa core */
-- 
2.9.3

[PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls

[Richard Leitner]

These controls mute/unmute the LINEOUT and headphone outputs of SGTL5000
using its CHIP_ANA_CTRL register.

Signed-off-by: Richard Leitner <dev@g0hl1n.net>
---
CHANGES v2: fix invert value for both controls
	(sorry I've missed that in my initial tests!)
---
 sound/soc/codecs/sgtl5000.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
index 527b759..a6af65d 100644
--- a/sound/soc/codecs/sgtl5000.c
+++ b/sound/soc/codecs/sgtl5000.c
@@ -411,6 +411,8 @@ static const struct snd_kcontrol_new sgtl5000_snd_controls[] = {
 			0, 8,
 			0x7f, 1,
 			headphone_volume),
+	SOC_SINGLE("Headphone Playback Switch", SGTL5000_CHIP_ANA_CTRL,
+			4, 1, 1),
 	SOC_SINGLE("Headphone Playback ZC Switch", SGTL5000_CHIP_ANA_CTRL,
 			5, 1, 0),
 
@@ -423,6 +425,7 @@ static const struct snd_kcontrol_new sgtl5000_snd_controls[] = {
 			SGTL5000_LINE_OUT_VOL_RIGHT_SHIFT,
 			0x1f, 1,
 			lineout_volume),
+	SOC_SINGLE("Lineout Playback Switch", SGTL5000_CHIP_ANA_CTRL, 8, 1, 1),
 };
 
 /* mute the codec used by alsa core */
-- 
2.9.3

Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls

[Richard Leitner]

Hi,
any comments, updates or ideas for improvement on that patch?

regards,
Richard

On Wed, 31 Aug 2016 09:26:31 +0200
Richard Leitner <dev@g0hl1n.net> wrote:

> These controls mute/unmute the LINEOUT and headphone outputs of SGTL5000
> using its CHIP_ANA_CTRL register.
> 
> Signed-off-by: Richard Leitner <dev@g0hl1n.net>
> ---
> CHANGES v2: fix invert value for both controls
> 	(sorry I've missed that in my initial tests!)
> ---
>  sound/soc/codecs/sgtl5000.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
> index 527b759..a6af65d 100644
> --- a/sound/soc/codecs/sgtl5000.c
> +++ b/sound/soc/codecs/sgtl5000.c
> @@ -411,6 +411,8 @@ static const struct snd_kcontrol_new sgtl5000_snd_controls[] = {
>  			0, 8,
>  			0x7f, 1,
>  			headphone_volume),
> +	SOC_SINGLE("Headphone Playback Switch", SGTL5000_CHIP_ANA_CTRL,
> +			4, 1, 1),
>  	SOC_SINGLE("Headphone Playback ZC Switch", SGTL5000_CHIP_ANA_CTRL,
>  			5, 1, 0),
>  
> @@ -423,6 +425,7 @@ static const struct snd_kcontrol_new sgtl5000_snd_controls[] = {
>  			SGTL5000_LINE_OUT_VOL_RIGHT_SHIFT,
>  			0x1f, 1,
>  			lineout_volume),
> +	SOC_SINGLE("Lineout Playback Switch", SGTL5000_CHIP_ANA_CTRL, 8, 1, 1),
>  };
>  
>  /* mute the codec used by alsa core */

Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

On Fri, Sep 09, 2016 at 09:46:45AM +0200, Richard Leitner wrote:
> Hi,
> any comments, updates or ideas for improvement on that patch?
> 
> regards,
> Richard
> 
> On Wed, 31 Aug 2016 09:26:31 +0200
> Richard Leitner <dev@g0hl1n.net> wrote:

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.
Sending content free pings just adds to the mail volume (if they are
seen at all) and if something has gone wrong you'll have to resend the
patches anyway.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls

[Richard Leitner]

On 09/09/2016 12:17 PM, Mark Brown wrote:
> On Fri, Sep 09, 2016 at 09:46:45AM +0200, Richard Leitner wrote:
>> Hi,
>> any comments, updates or ideas for improvement on that patch?
>>
>> On Wed, 31 Aug 2016 09:26:31 +0200
>> Richard Leitner <dev@g0hl1n.net> wrote:
>
> Please don't top post, reply in line with needed context.  This allows
> readers to readily follow the flow of conversation and understand what
> you are talking about and also helps ensure that everything in the
> discussion is being addressed.

Ok, thanks for that hint. I'm pretty new to this, therefore I hope I'll 
get everything right from now on.


>
> Please don't send content free pings and please allow a reasonable time
> for review.  People get busy, go on holiday, attend conferences and so
> on so unless there is some reason for urgency (like critical bug fixes)
> please allow at least a couple of weeks for review.  If there have been
> review comments then people may be waiting for those to be addressed.
> Sending content free pings just adds to the mail volume (if they are
> seen at all) and if something has gone wrong you'll have to resend the
> patches anyway.
>

So it's been a month now, is this a reasonable time to ping?

Although it's a pretty small change I don't want it to get lost...

regards,
Richard

Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

On Mon, Oct 10, 2016 at 02:52:38PM +0200, Richard Leitner wrote:
> On 09/09/2016 12:17 PM, Mark Brown wrote:

> > Please don't send content free pings and please allow a reasonable time
> > for review.  People get busy, go on holiday, attend conferences and so
> > on so unless there is some reason for urgency (like critical bug fixes)
> > please allow at least a couple of weeks for review.  If there have been
> > review comments then people may be waiting for those to be addressed.
> > Sending content free pings just adds to the mail volume (if they are
> > seen at all) and if something has gone wrong you'll have to resend the
> > patches anyway.

> So it's been a month now, is this a reasonable time to ping?

To repeat please don't send content free pings at all for the reasons
explained above.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]