Re: [PATCH 0/9] ASoC: Intel: Skylake: Driver updates

[Vinod Koul <vinod.koul@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1525 bytes --]

On Wed, Sep 14, 2016 at 05:50:43PM +0100, Mark Brown wrote:
> On Wed, Aug 24, 2016 at 06:03:12PM +0530, Vinod Koul wrote:
> 
> >  - The module instance IDs are manged in driver now.
> 
> > Dharageswari R (5):
> >   ASoC: Intel: Skylake: Unload all the loadable modules
> >   ASoC: Intel: Skylake: Create dynamic instance ids for DSP modules
> >   ASoC: Intel: Skylake: Use private instance id of modules in IPC
> >   ASoC: Intel: Skylake: Table for module instance id and private id
> >   ASoC: Intel: Skylake: Override the actual instance id's to pvt_id's
> 
> I really don't understand what the point of these changes is at all,
> sorry.  This makes it really hard to tell if they're doing what they're
> supposed to.

No issues, I will try to add more details on these bits.

The point of these changes is to allocate and manage an 'instance id' in
kernel.

Topology gives its own ID but thats just a free running values and we may
have more instance in complete graph than max allowed instance for that
module as not all parts of graph will be operation simultaneously.

So the way is to allocate and manage them in driver. We have used ffz to
maintain the ids, but ffz works on 32 bits, the max instance of some modules
is more than that so we added implementation on top of ffz for 128bits.

Later the patches use this and add a table for quick ref of used ids for
sending to DSPs.

Please do let me know if it helps, will add more details in patch changelogs...

Thanks
-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]