From: Krzysztof Kozlowski <krzk@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: trivial@kernel.org, Krzysztof Kozlowski <krzk@kernel.org>,
Sangbeom Kim <sbkim73@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: samsung: add missing \n to end of pr_err messages
Date: Fri, 16 Sep 2016 23:47:57 +0200 [thread overview]
Message-ID: <20160916214757.GA22983@kozik-lap> (raw)
In-Reply-To: <20160916173053.13138-1-colin.king@canonical.com>
On Fri, Sep 16, 2016 at 06:30:53PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trival fix, some pr_err messages are missing a \n, so add it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> sound/soc/samsung/ac97.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Hi,
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Also probably converting everything to dev_* would make sense as well
but it is not trivial.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-09-16 21:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-16 17:30 [PATCH] ASoC: samsung: add missing \n to end of pr_err messages Colin King
2016-09-16 21:47 ` Krzysztof Kozlowski [this message]
2016-09-25 5:58 ` Applied "ASoC: samsung: add missing \n to end of pr_err messages" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916214757.GA22983@kozik-lap \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).