From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Danny Milosavljevic <dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>,
Takashi Iwai <tiwai-IBi9RG/b67k@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v4 2/3] ASoC: rename some sun7i-only registers
Date: Sun, 18 Sep 2016 22:17:47 +0200 [thread overview]
Message-ID: <20160918201747.GL17518@lukather> (raw)
In-Reply-To: <20160915163630.18026-3-dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 598 bytes --]
On Thu, Sep 15, 2016 at 06:36:29PM +0200, Danny Milosavljevic wrote:
> ASoC: sun4i-codec: Some of the registers are sun7i-only.
That line is useless, you already have the commit title.
>
> Therefore rename "SUN4I_CODEC_SYS_VERI" to "SUN7I_CODEC_AC_DAC_CAL" and
> rename "SUN4I_CODEC_AC_MIC_PHONE_CAL" to "SUN7I_CODEC_AC_MIC_PHONE_CAL".
And removing it, you could make a real sentence, like:
Some of the registers defined in the driver are only usable on the
A20. Rename these registers.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-09-18 20:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 16:36 [PATCH v4 0/3] ASoC: sun4i-codec: Distinguish sun4i from sun7i Danny Milosavljevic
[not found] ` <20160915163630.18026-1-dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2016-09-15 16:36 ` [PATCH v4 1/3] ASoC: sun4i-codec: rename sun4i_codec_widgets for consistency Danny Milosavljevic
[not found] ` <20160915163630.18026-2-dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2016-09-18 20:04 ` Maxime Ripard
2016-09-15 16:36 ` [PATCH v4 2/3] ASoC: rename some sun7i-only registers Danny Milosavljevic
[not found] ` <20160915163630.18026-3-dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2016-09-18 20:17 ` Maxime Ripard [this message]
2016-09-15 16:36 ` [PATCH v4 3/3] ASoC: sun4i-codec: Add custom regmap configs Danny Milosavljevic
[not found] ` <20160915163630.18026-4-dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org>
2016-09-18 20:27 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160918201747.GL17518@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=dannym-bxPqe3T81XXwRsdMLXbzog@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=tiwai-IBi9RG/b67k@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).