From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Mark Brown <broonie@kernel.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
alsa-devel@alsa-project.org,
Mylene Josserand <mylene.josserand@free-electrons.com>,
Liam Girdwood <lgirdwood@gmail.com>, Chen-Yu Tsai <wens@csie.org>
Subject: Re: DAPM over two regmaps (and a mailbox)
Date: Mon, 19 Sep 2016 13:34:15 +0200 [thread overview]
Message-ID: <20160919113415.GM8719@lukather> (raw)
In-Reply-To: <20160919111247.GL10189@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 1233 bytes --]
On Mon, Sep 19, 2016 at 12:12:47PM +0100, Mark Brown wrote:
> On Mon, Sep 19, 2016 at 12:54:19PM +0200, Maxime Ripard wrote:
>
> > That codec is mapped in memory, however, we have a bunch of DAPM
> > widgets that are mapped in a separate register space, that should
> > probably be exposed through a syscon (but isn't yet).
>
> Why not just represent those as a separate device?
I don't know, this seems to be supplies to muxers, mixers, DACs, the
amplifier (and the amplifier volume too, even though that's not a
widget), and it looks really intertwinned, how would you separate
them?
> > To make things worse, the register in the syscon behaves as a mailbox,
> > where you actually have to set in that register the address you want
> > to modify and the new value, in a single write. This also seem to
> > deviate from the usual DAPM access pattern.
>
> This is totally fine, just use events for the things that aren't simple
> register updates - there are a large number of examples in the tree,
> simple register access is totally optional.
Ah, yes, that seems to be just right. Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-09-19 11:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 10:54 DAPM over two regmaps (and a mailbox) Maxime Ripard
2016-09-19 11:12 ` Mark Brown
2016-09-19 11:34 ` Maxime Ripard [this message]
2016-09-19 12:00 ` Mark Brown
2016-09-19 14:56 ` Chen-Yu Tsai
2016-09-19 19:15 ` Maxime Ripard
2016-09-20 0:32 ` Chen-Yu Tsai
2016-09-20 0:41 ` Chen-Yu Tsai
2016-09-20 6:41 ` Maxime Ripard
2016-09-20 15:54 ` Chen-Yu Tsai
2016-09-20 6:41 ` Maxime Ripard
2016-09-20 10:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919113415.GM8719@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=mylene.josserand@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).