From: Marek Vasut <marex@denx.de>
To: alsa-devel@alsa-project.org
Cc: Marek Vasut <marex@denx.de>, Xiubo Li <Xiubo.Lee@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>, Timur Tabi <timur@tabi.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Mark Brown <broonie@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: [PATCH 3/5] ASoC: fsl_spdif: use flat regmap cache
Date: Mon, 19 Sep 2016 21:30:27 +0200 [thread overview]
Message-ID: <20160919193029.8119-3-marex@denx.de> (raw)
In-Reply-To: <20160919193029.8119-1-marex@denx.de>
Same as commit ce492b3b8f99cf9d2f807ec22d8805c996a09503
Subject: drm/fsl-dcu: use flat regmap cache
Using flat regmap cache instead of RB-tree to avoid the following
lockdep warning on driver load:
WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:2871 lockdep_trace_alloc+0x104/0x128
DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags))
The RB-tree regmap cache needs to allocate new space on first
writes. However, allocations in an atomic context (e.g. when a
spinlock is held) are not allowed. The function regmap_write
calls map->lock, which acquires a spinlock in the fast_io case.
Since the driver uses MMIO, the regmap bus of type regmap_mmio
is being used which has fast_io set to true.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Timur Tabi <timur@tabi.org>
Cc: Xiubo Li <Xiubo.Lee@gmail.com>
---
sound/soc/fsl/fsl_spdif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index beec793..1ff467c 100644
--- a/sound/soc/fsl/fsl_spdif.c
+++ b/sound/soc/fsl/fsl_spdif.c
@@ -1103,7 +1103,7 @@ static const struct regmap_config fsl_spdif_regmap_config = {
.readable_reg = fsl_spdif_readable_reg,
.volatile_reg = fsl_spdif_volatile_reg,
.writeable_reg = fsl_spdif_writeable_reg,
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_FLAT,
};
static u32 fsl_spdif_txclk_caldiv(struct fsl_spdif_priv *spdif_priv,
--
2.9.3
next prev parent reply other threads:[~2016-09-19 19:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 19:30 [PATCH 1/5] ASoC: fsl_asrc: use flat regmap cache Marek Vasut
2016-09-19 19:30 ` [PATCH 2/5] ASoC: fsl_esai: " Marek Vasut
2016-09-21 12:56 ` Applied "ASoC: fsl_esai: use flat regmap cache" to the asoc tree Mark Brown
2016-09-19 19:30 ` Marek Vasut [this message]
2016-09-21 12:56 ` Applied "ASoC: fsl_spdif: " Mark Brown
2016-09-19 19:30 ` [PATCH 4/5] ASoC: fsl_ssi: use flat regmap cache Marek Vasut
2016-09-21 12:55 ` Applied "ASoC: fsl_ssi: use flat regmap cache" to the asoc tree Mark Brown
2016-09-21 16:28 ` [PATCH 4/5] ASoC: fsl_ssi: use flat regmap cache Maciej S. Szmigiero
2016-09-21 19:32 ` Marek Vasut
2016-09-21 22:18 ` Maciej S. Szmigiero
2016-09-21 22:45 ` Marek Vasut
2016-09-21 23:33 ` Maciej S. Szmigiero
2016-09-22 10:45 ` Mark Brown
2016-09-22 14:37 ` Maciej S. Szmigiero
2016-09-22 15:27 ` Marek Vasut
2016-09-22 23:38 ` Maciej S. Szmigiero
2016-09-26 19:13 ` Mark Brown
2016-09-26 19:25 ` Marek Vasut
2016-09-26 21:03 ` Mark Brown
2016-09-27 23:23 ` Maciej S. Szmigiero
2016-09-27 23:29 ` Marek Vasut
2016-09-28 0:04 ` Maciej S. Szmigiero
2016-09-28 19:09 ` Marek Vasut
2016-09-22 15:23 ` Marek Vasut
2016-09-19 19:30 ` [PATCH 5/5] ASoC: fsl_ssi: Remove .num_reg_defaults_raw from regmap_config Marek Vasut
2016-09-20 17:56 ` Mark Brown
2016-09-20 18:23 ` Marek Vasut
2016-09-21 12:55 ` Applied "ASoC: fsl_ssi: Remove .num_reg_defaults_raw from regmap_config" to the asoc tree Mark Brown
2016-09-20 6:50 ` [PATCH 1/5] ASoC: fsl_asrc: use flat regmap cache Nicolin Chen
2016-09-20 18:07 ` Fabio Estevam
2016-09-21 12:56 ` Applied "ASoC: fsl_asrc: use flat regmap cache" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160919193029.8119-3-marex@denx.de \
--to=marex@denx.de \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=lgirdwood@gmail.com \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).