From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: broonie@kernel.org
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
lgirdwood@gmail.com
Subject: Re: [PATCH 5/7] ASoC: wm_adsp: Put DSP into low power state between loading and running
Date: Wed, 21 Sep 2016 17:14:01 +0100 [thread overview]
Message-ID: <20160921161401.GV21682@localhost.localdomain> (raw)
In-Reply-To: <1474375956-10443-6-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Tue, Sep 20, 2016 at 01:52:34PM +0100, Charles Keepax wrote:
> Between when we load the DSP and when it actually starts running put the
> core into a lower power state where the memory is retained but nothing
> is clocked.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> @@ -2344,6 +2355,11 @@ int wm_adsp2_event(struct snd_soc_dapm_widget *w,
> if (!dsp->booted)
> return -EIO;
>
> + ret = regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL,
> + ADSP2_SYS_ENA, ADSP2_SYS_ENA);
> + if (ret != 0)
> + goto err;
> +
We actually need to wait for RAM_RDY again here, I will fire out
a new version of the patches in the next day or two.
Thanks,
Charles
next prev parent reply other threads:[~2016-09-21 16:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 12:52 [PATCH 0/7] Allow ADSPs to be preloaded with firmware Charles Keepax
2016-09-20 12:52 ` [PATCH 1/7] ASoC: arizona: Attach SYSCLK to DSP preloaders Charles Keepax
2016-09-25 5:58 ` Applied "ASoC: arizona: Attach SYSCLK to DSP preloaders" to the asoc tree Mark Brown
2016-09-20 12:52 ` [PATCH 2/7] ASoC: wm_adsp: Make DSP preloader a supply widget Charles Keepax
2016-09-25 5:58 ` Applied "ASoC: wm_adsp: Make DSP preloader a supply widget" to the asoc tree Mark Brown
2016-09-20 12:52 ` [PATCH 3/7] ASoC: wm_adsp: Separate concept of booted and running Charles Keepax
2016-09-25 5:58 ` Applied "ASoC: wm_adsp: Separate concept of booted and running" to the asoc tree Mark Brown
2016-09-20 12:52 ` [PATCH 4/7] ASoC: wm_adsp: Move control cache sync out of preloader Charles Keepax
2016-09-25 5:58 ` Applied "ASoC: wm_adsp: Move control cache sync out of preloader" to the asoc tree Mark Brown
2016-09-20 12:52 ` [PATCH 5/7] ASoC: wm_adsp: Put DSP into low power state between loading and running Charles Keepax
2016-09-21 16:14 ` Charles Keepax [this message]
2016-09-20 12:52 ` [PATCH 6/7] ASoC: wm_adsp: Allow preloader to do the final shutdown of the DSP Charles Keepax
2016-09-20 12:52 ` [PATCH 7/7] ASoC: wm_adsp: Add mechanism to preload firmware on a core Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921161401.GV21682@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).