* [PATCH] ASOC: max9867/rt5616/wm8960: remove usage of obsoleted TLV-related macro
@ 2016-09-26 23:51 Takashi Sakamoto
2016-09-27 8:49 ` Charles Keepax
2016-09-27 16:17 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Takashi Sakamoto @ 2016-09-26 23:51 UTC (permalink / raw)
To: tiwai, broonie, lgirdwood
Cc: Oder Chiou, Bard Liao, alsa-devel, patches, anish kumar
TLV_DB_RANGE_HEAD macro was obsoleted by commit bf1d1c9b6179 ("ALSA: tlv:
add DECLARE_TLV_DB_RANGE()").
This commit removes usage of the macro, with the obsoleting macro renamed
to SNDRV_CTL_TLVD_DECLARE_DB_RANGE().
Cc: Bard Liao <bardliao@realtek.com>
Cc: Oder Chiou <oder_chiou@realtek.com>
Cc: patches@opensource.wolfsonmicro.com
Cc: anish kumar <yesanishhere@gmail.com>
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
sound/soc/codecs/max9867.c | 5 ++---
sound/soc/codecs/rt5616.c | 5 ++---
sound/soc/codecs/wm8960.c | 5 ++---
3 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c
index 2a22fdd..1aa838f 100644
--- a/sound/soc/codecs/max9867.c
+++ b/sound/soc/codecs/max9867.c
@@ -38,11 +38,10 @@ static DECLARE_TLV_DB_SCALE(max9860_capture_tlv, -600, 200, 0);
static DECLARE_TLV_DB_SCALE(max9860_mic_tlv, 2000, 100, 1);
static DECLARE_TLV_DB_SCALE(max9860_adc_left_tlv, -1200, 100, 1);
static DECLARE_TLV_DB_SCALE(max9860_adc_right_tlv, -1200, 100, 1);
-static const unsigned int max98088_micboost_tlv[] = {
- TLV_DB_RANGE_HEAD(2),
+static const SNDRV_CTL_TLVD_DECLARE_DB_RANGE(max98088_micboost_tlv,
0, 1, TLV_DB_SCALE_ITEM(0, 2000, 0),
2, 2, TLV_DB_SCALE_ITEM(3000, 0, 0),
-};
+);
static const struct snd_kcontrol_new max9867_snd_controls[] = {
SOC_DOUBLE_R("Master Playback Volume", MAX9867_LEFTVOL,
diff --git a/sound/soc/codecs/rt5616.c b/sound/soc/codecs/rt5616.c
index f527b5b..851704f 100644
--- a/sound/soc/codecs/rt5616.c
+++ b/sound/soc/codecs/rt5616.c
@@ -294,8 +294,7 @@ static const DECLARE_TLV_DB_SCALE(adc_vol_tlv, -17625, 375, 0);
static const DECLARE_TLV_DB_SCALE(adc_bst_tlv, 0, 1200, 0);
/* {0, +20, +24, +30, +35, +40, +44, +50, +52} dB */
-static unsigned int bst_tlv[] = {
- TLV_DB_RANGE_HEAD(7),
+static const SNDRV_CTL_TLVD_DECLARE_DB_RANGE(bst_tlv,
0, 0, TLV_DB_SCALE_ITEM(0, 0, 0),
1, 1, TLV_DB_SCALE_ITEM(2000, 0, 0),
2, 2, TLV_DB_SCALE_ITEM(2400, 0, 0),
@@ -303,7 +302,7 @@ static unsigned int bst_tlv[] = {
6, 6, TLV_DB_SCALE_ITEM(4400, 0, 0),
7, 7, TLV_DB_SCALE_ITEM(5000, 0, 0),
8, 8, TLV_DB_SCALE_ITEM(5200, 0, 0),
-};
+);
static const struct snd_kcontrol_new rt5616_snd_controls[] = {
/* Headphone Output Volume */
diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
index d7f444f..3d8c756 100644
--- a/sound/soc/codecs/wm8960.c
+++ b/sound/soc/codecs/wm8960.c
@@ -226,11 +226,10 @@ static const DECLARE_TLV_DB_SCALE(dac_tlv, -12750, 50, 1);
static const DECLARE_TLV_DB_SCALE(bypass_tlv, -2100, 300, 0);
static const DECLARE_TLV_DB_SCALE(out_tlv, -12100, 100, 1);
static const DECLARE_TLV_DB_SCALE(lineinboost_tlv, -1500, 300, 1);
-static const unsigned int micboost_tlv[] = {
- TLV_DB_RANGE_HEAD(2),
+static const SNDRV_CTL_TLVD_DECLARE_DB_RANGE(micboost_tlv,
0, 1, TLV_DB_SCALE_ITEM(0, 1300, 0),
2, 3, TLV_DB_SCALE_ITEM(2000, 900, 0),
-};
+);
static const struct snd_kcontrol_new wm8960_snd_controls[] = {
SOC_DOUBLE_R_TLV("Capture Volume", WM8960_LINVOL, WM8960_RINVOL,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASOC: max9867/rt5616/wm8960: remove usage of obsoleted TLV-related macro
2016-09-26 23:51 [PATCH] ASOC: max9867/rt5616/wm8960: remove usage of obsoleted TLV-related macro Takashi Sakamoto
@ 2016-09-27 8:49 ` Charles Keepax
2016-09-27 16:17 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2016-09-27 8:49 UTC (permalink / raw)
To: Takashi Sakamoto
Cc: Oder Chiou, alsa-devel, anish kumar, tiwai, patches, lgirdwood,
broonie, Bard Liao
On Tue, Sep 27, 2016 at 08:51:00AM +0900, Takashi Sakamoto wrote:
> TLV_DB_RANGE_HEAD macro was obsoleted by commit bf1d1c9b6179 ("ALSA: tlv:
> add DECLARE_TLV_DB_RANGE()").
>
> This commit removes usage of the macro, with the obsoleting macro renamed
> to SNDRV_CTL_TLVD_DECLARE_DB_RANGE().
>
> Cc: Bard Liao <bardliao@realtek.com>
> Cc: Oder Chiou <oder_chiou@realtek.com>
> Cc: patches@opensource.wolfsonmicro.com
> Cc: anish kumar <yesanishhere@gmail.com>
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASOC: max9867/rt5616/wm8960: remove usage of obsoleted TLV-related macro
2016-09-26 23:51 [PATCH] ASOC: max9867/rt5616/wm8960: remove usage of obsoleted TLV-related macro Takashi Sakamoto
2016-09-27 8:49 ` Charles Keepax
@ 2016-09-27 16:17 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2016-09-27 16:17 UTC (permalink / raw)
To: Takashi Sakamoto
Cc: Oder Chiou, alsa-devel, anish kumar, tiwai, patches, lgirdwood,
Bard Liao
[-- Attachment #1.1: Type: text/plain, Size: 437 bytes --]
On Tue, Sep 27, 2016 at 08:51:00AM +0900, Takashi Sakamoto wrote:
> ---
> sound/soc/codecs/max9867.c | 5 ++---
> sound/soc/codecs/rt5616.c | 5 ++---
> sound/soc/codecs/wm8960.c | 5 ++---
> 3 files changed, 6 insertions(+), 9 deletions(-)
Please send one patch per driver where there is no interdependency
between changes, this makes it much easier to apply your changes since
I keep changes for each driver on a separate branch.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-27 16:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-26 23:51 [PATCH] ASOC: max9867/rt5616/wm8960: remove usage of obsoleted TLV-related macro Takashi Sakamoto
2016-09-27 8:49 ` Charles Keepax
2016-09-27 16:17 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).