From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"kernel@stlinux.com" <kernel@stlinux.com>,
Takashi Iwai <tiwai@suse.de>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
Takashi Sakamoto <o-takashi@sakamocchi.jp>,
Vinod Koul <vinod.koul@intel.com>,
"broonie@kernel.org" <broonie@kernel.org>,
Moise GERGAUD <moise.gergaud@st.com>
Subject: Re: [PATCH] ASoC: core: allow control index different from 0
Date: Tue, 11 Oct 2016 09:30:24 +0100 [thread overview]
Message-ID: <20161011083024.GD1952@localhost.localdomain> (raw)
In-Reply-To: <75636c51-baf2-8793-b39b-5961845793c1@st.com>
On Mon, Oct 10, 2016 at 11:26:00AM +0200, Arnaud Pouliquen wrote:
>
>
> On 10/09/2016 05:05 AM, Takashi Sakamoto wrote:
> > Sorry to be late. I've review your driver in for-next branch of
> > maintainer's tree.
> >
> > On Oct 8 2016 01:41, Arnaud Pouliquen wrote:
> > But I still oppose this idea. This idea allows drivers to add control
> > element sets of different types (int/int64/bytes etc...) with the same
> > name and different index number. This certainly brings confusions to
> > applications.
> Today is already possible using the device or subdevice field instead of
> index.
> >
> > In a framework of ALSA SoC part, several drivers are associated to one
> > sound card instance can add their own control element sets. There's no
> > mechanism to prevent my concern. This idea is bad.
> Please tell me if i misunderstand. So for you, there is no real solution
> to do it in a generic way. Drivers has to implement it, if they want to
> support.
>
> Another solution is to declare a card per instance of control.
> This should work for my use case and for use cases with several codecs
> that declare same controls. But this should not work for DPCM...
> The drawback for my use case, would be that i need to declare one card
> per PCM device.
Apologies if I am missing the mark here, I haven't been following
this thread in great detail. But if your main concern here is
multiple instances of the same CODEC creating the same controls
the normal way to handle that in ASoC is using a
snd_soc_codec_conf struct which lets you add a prefix to all the
controls from a specific instance of a CODEC. See
sound/soc/samsung/bells.c for an example using it.
Thanks,
Charles
next prev parent reply other threads:[~2016-10-11 8:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 15:36 [PATCH] ASoC: core: allow control index different from 0 Arnaud Pouliquen
2016-10-05 6:59 ` Takashi Sakamoto
2016-10-05 8:41 ` Arnaud Pouliquen
2016-10-06 14:01 ` Takashi Sakamoto
2016-10-07 16:41 ` Arnaud Pouliquen
2016-10-09 3:05 ` Takashi Sakamoto
2016-10-10 9:26 ` Arnaud Pouliquen
2016-10-10 13:03 ` Takashi Sakamoto
2016-10-10 14:38 ` Arnaud Pouliquen
2016-10-11 8:30 ` Charles Keepax [this message]
2016-10-11 13:58 ` Arnaud Pouliquen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011083024.GD1952@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@st.com \
--cc=broonie@kernel.org \
--cc=kernel@stlinux.com \
--cc=lgirdwood@gmail.com \
--cc=moise.gergaud@st.com \
--cc=o-takashi@sakamocchi.jp \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).