From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Matt Flax <flatmax@flatmax.org>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v3] ASoc: wm8580: Add the wm8581 codec to the driver
Date: Thu, 20 Oct 2016 10:45:19 +0100 [thread overview]
Message-ID: <20161020094519.GM3207@localhost.localdomain> (raw)
In-Reply-To: <1476919754-9636-1-git-send-email-flatmax@flatmax.org>
On Thu, Oct 20, 2016 at 10:29:14AM +1100, Matt Flax wrote:
> This patch adds support for the wm8581 codec to the wm8580 driver.
> The wm8581 codec hardware adds a fourth DAC and otherwise is
> compatible with the wm8580 codec.
>
> of_device_id data is used to allow the driver to select the
> suitable DAC count specified in the device tree codec selection.
> The wm8580_driver_data struct is used to store the number of DACs.
>
> The snd_soc_dai_driver no longer lists the channels_max for the
> playback substream. This variable is set during the i2c probe
> from the of_device_id supplied wm8580_driver_data struct.
>
> With knowledge of the number of DACs in use, the DAC4 controls,
> widgets and routes are added as required for DAC4.
>
> The device tree documentation for the wm8580 is altered to list
> the wm8581 codec support, as is the Kconfig file.
>
> Signed-off-by: Matt Flax <flatmax@flatmax.org>
> ---
Looks good to me.
Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
next prev parent reply other threads:[~2016-10-20 9:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 18:24 [PATCH] ASoc: wm8580: Add the wm8581 codec to the driver Matt Flax
2016-10-19 9:22 ` Charles Keepax
2016-10-19 23:22 ` Matt Flax
2016-10-19 23:29 ` [PATCH v3] " Matt Flax
2016-10-20 9:45 ` Charles Keepax [this message]
2016-10-24 17:24 ` Mark Brown
2016-10-24 17:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020094519.GM3207@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=flatmax@flatmax.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).