Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Valentin <benpicco@googlemail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: No surround sound with ALC892 on B150M Pro4/D3 - fixed with hdajackretask
Date: Thu, 20 Oct 2016 23:47:47 +0200	[thread overview]
Message-ID: <20161020234747.5d1da301@nashorn> (raw)
In-Reply-To: <s5hpomv1fyv.wl-tiwai@suse.de>

On Thu, 20 Oct 2016 12:18:16 +0200
Takashi Iwai <tiwai@suse.de> wrote:

> Does the patch below work for you?

Thank you, that works - there is only one typo ;)

> ---
>  sound/pci/hda/patch_realtek.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c
> b/sound/pci/hda/patch_realtek.c index b582d57fe184..284315555229
> 100644 --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
>  static const struct hda_fixup alc662_fixups[] = {
> @@ -6901,6 +6902,16 @@ static const struct hda_fixup alc662_fixups[]
> = { { }
>  		}
>  	},
> +	[ALC892_FIXUP_ASROCK_MOBO] = {
> +		.type = HDA_FIXUP_PINS,
> +		.v.pins = (const struct hda_pintbl[]) {
> +			{ 0x15, 0x40f000f0 }, /* disabled */
> +			{ 0x16, 0x40f000f0 }, /* disabled */
> +			{ 0x18, 0x01014011 }, /* LO */
> +			{ 0x18, 0x01014012 }, /* LO */
			^^^^^^
should be
  +			{ 0x15, 0x40f000f0 }, /* disabled */
  +			{ 0x16, 0x40f000f0 }, /* disabled */
  +			{ 0x18, 0x01014011 }, /* LO */
  +			{ 0x1a, 0x01014012 }, /* LO */

otherwise there will be no center/lfe channel.

Thanks!
Benjamin

  reply	other threads:[~2016-10-20 21:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 22:50 No surround sound with ALC892 on B150M Pro4/D3 - fixed with hdajackretask Benjamin Valentin
2016-10-20 10:18 ` Takashi Iwai
2016-10-20 21:47   ` Benjamin Valentin [this message]
2016-10-21  7:20     ` Takashi Iwai
2016-10-21  8:02       ` Benjamin Valentin
2016-10-25  8:15         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161020234747.5d1da301@nashorn \
    --to=benpicco@googlemail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox