From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Takashi Iwai <tiwai@suse.de>,
Mengdong Lin <mengdong.lin@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Jin Yao <yao.jin@linux.intel.co>, Simon <horms@verge.net.au>
Subject: Re: [PATCH 1/4] ASoC: rt286: rt286_mic_detect() uses component
Date: Wed, 26 Oct 2016 13:12:08 +0100 [thread overview]
Message-ID: <20161026121208.GA25322@sirena.org.uk> (raw)
In-Reply-To: <20161026035045.GB3000@localhost>
[-- Attachment #1.1: Type: text/plain, Size: 627 bytes --]
On Wed, Oct 26, 2016 at 09:20:45AM +0530, Vinod Koul wrote:
> into rtd internals. So would make sense to combine two suggestion and add an
> API:
> struct snd_soc_codec *snd_soc_get_codec(struct snd_soc_pcm_runtime *rtd)
> {
> return rtd->codec;
> }
> then we can use this is drivers.
That interface does bake in the CPU/CODEC distinction which is something
we want to get away from with componentization since it makes things
more complicated with situations like CODEC<->CODEC links. OTOH we're
looking up a CODEC rather than a component here so it's going to need to
change again anyway so it probably doesn't matter.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-10-26 12:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 4:28 [PATCH 0/5] ASoC: Component has suspend/resume support Kuninori Morimoto
2016-10-21 4:29 ` [PATCH 1/4] ASoC: rt286: rt286_mic_detect() uses component Kuninori Morimoto
2016-10-24 6:57 ` Takashi Iwai
2016-10-24 7:06 ` Lars-Peter Clausen
2016-10-24 7:43 ` Kuninori Morimoto
2016-10-24 9:19 ` Lars-Peter Clausen
2016-10-26 3:50 ` Vinod Koul
2016-10-26 4:48 ` Kuninori Morimoto
2016-10-26 16:06 ` Vinod Koul
2016-10-26 6:56 ` Lars-Peter Clausen
2016-10-26 16:08 ` Vinod Koul
2016-10-26 12:12 ` Mark Brown [this message]
2016-10-21 4:29 ` [PATCH 2/4] ASoC: rt5670: rt5670_jack_suspend/resume() " Kuninori Morimoto
2016-10-21 4:31 ` [PATCH 3/4] ASoC: core: add component_dev_list on Card Kuninori Morimoto
2016-10-21 4:32 ` [PATCH 4/4] ASoC: add Component level suspend/resume Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026121208.GA25322@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=mengdong.lin@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
--cc=yao.jin@linux.intel.co \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).