From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH 11/13] ALSA: Deletion of checks before the function call "iounmap" Date: Wed, 26 Oct 2016 15:42:45 +0300 Message-ID: <20161026124245.GR4418@mwanda> References: <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54A9355F.4050102@users.sourceforge.net> <54A941C1.4020906@users.sourceforge.net> <20161026122605.GA3911@mwanda> <1477484939.4059.35.camel@sipsolutions.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1477484939.4059.35.camel@sipsolutions.net> Sender: linux-kernel-owner@vger.kernel.org To: Johannes Berg Cc: SF Markus Elfring , Jaroslav Kysela , Clemens Ladisch , Russell King , Takashi Iwai , Thibaut Varene , alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-parisc@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: alsa-devel@alsa-project.org On Wed, Oct 26, 2016 at 02:28:59PM +0200, Johannes Berg wrote: > On Wed, 2016-10-26 at 15:26 +0300, Dan Carpenter wrote: > > Someone was just mentioning in another thread that removing the check > > from iounmap() is not portable to other arches and then I remembered > > that Markus removed a bunch of these. > > > > We should consider reverting this, perhaps? > > Can't we teach all architectures? Not that reverting it would be a > problem. We probably should. I just didn't want to suggest it, in case it sounds like volunteering... I'm not going to be able to do it because I'm on the road for a bit. regards, dan carpenter