alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] snd-usb-audio: Add quirk for Syntek STK1160.
@ 2016-10-27  8:13 Marcel Hasler
  0 siblings, 0 replies; 2+ messages in thread
From: Marcel Hasler @ 2016-10-27  8:13 UTC (permalink / raw)
  To: alsa-devel

The stk1160 chip needs QUIRK_AUDIO_ALIGN_TRANSFER. This patch resolves the issue reported on the
mailing list (http://marc.info/?l=linux-sound&m=139223599126215&w=2) and also fixes bug 180071
(https://bugzilla.kernel.org/show_bug.cgi?id=180071).

Signed-off-by: Marcel Hasler <mahasler@gmail.com>
---
 sound/usb/quirks-table.h | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
index c60a776..8a59d47 100644
--- a/sound/usb/quirks-table.h
+++ b/sound/usb/quirks-table.h
@@ -2907,6 +2907,23 @@ AU0828_DEVICE(0x2040, 0x7260, "Hauppauge", "HVR-950Q"),
 AU0828_DEVICE(0x2040, 0x7213, "Hauppauge", "HVR-950Q"),
 AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"),
 
+/* Syntek STK1160 */
+{
+	.match_flags = USB_DEVICE_ID_MATCH_DEVICE |
+		       USB_DEVICE_ID_MATCH_INT_CLASS |
+		       USB_DEVICE_ID_MATCH_INT_SUBCLASS,
+	.idVendor = 0x05e1,
+	.idProduct = 0x0408,
+	.bInterfaceClass = USB_CLASS_AUDIO,
+	.bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL,
+	.driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
+		.vendor_name = "Syntek",
+		.product_name = "STK1160",
+		.ifnum = QUIRK_ANY_INTERFACE,
+		.type = QUIRK_AUDIO_ALIGN_TRANSFER
+	}
+},
+
 /* Digidesign Mbox */
 {
 	/* Thanks to Clemens Ladisch <clemens@ladisch.de> */
-- 
2.10.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] snd-usb-audio: Add quirk for Syntek STK1160.
       [not found] <20161026224227.GA7683@arch-desktop>
@ 2016-10-27 10:16 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2016-10-27 10:16 UTC (permalink / raw)
  To: Marcel Hasler; +Cc: alsa-devel

On Thu, 27 Oct 2016 00:42:27 +0200,
Marcel Hasler wrote:
> 
> The stk1160 chip needs QUIRK_AUDIO_ALIGN_TRANSFER. This patch resolves the issue reported on the
> mailing list (http://marc.info/?l=linux-sound&m=139223599126215&w=2) and also fixes bug 180071
> (https://bugzilla.kernel.org/show_bug.cgi?id=180071).
> 
> Signed-off-by: Marcel Hasler <mahasler@gmail.com>

Thanks, applied now, as the fix looks trivial.
But at the next, please put Cc to alsa-devel ML.


Takashi

> ---
>  sound/usb/quirks-table.h | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/sound/usb/quirks-table.h b/sound/usb/quirks-table.h
> index c60a776..8a59d47 100644
> --- a/sound/usb/quirks-table.h
> +++ b/sound/usb/quirks-table.h
> @@ -2907,6 +2907,23 @@ AU0828_DEVICE(0x2040, 0x7260, "Hauppauge", "HVR-950Q"),
>  AU0828_DEVICE(0x2040, 0x7213, "Hauppauge", "HVR-950Q"),
>  AU0828_DEVICE(0x2040, 0x7270, "Hauppauge", "HVR-950Q"),
>  
> +/* Syntek STK1160 */
> +{
> +	.match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> +		       USB_DEVICE_ID_MATCH_INT_CLASS |
> +		       USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> +	.idVendor = 0x05e1,
> +	.idProduct = 0x0408,
> +	.bInterfaceClass = USB_CLASS_AUDIO,
> +	.bInterfaceSubClass = USB_SUBCLASS_AUDIOCONTROL,
> +	.driver_info = (unsigned long) &(const struct snd_usb_audio_quirk) {
> +		.vendor_name = "Syntek",
> +		.product_name = "STK1160",
> +		.ifnum = QUIRK_ANY_INTERFACE,
> +		.type = QUIRK_AUDIO_ALIGN_TRANSFER
> +	}
> +},
> +
>  /* Digidesign Mbox */
>  {
>  	/* Thanks to Clemens Ladisch <clemens@ladisch.de> */
> -- 
> 2.10.1
> 
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-27 10:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-27  8:13 [PATCH] snd-usb-audio: Add quirk for Syntek STK1160 Marcel Hasler
     [not found] <20161026224227.GA7683@arch-desktop>
2016-10-27 10:16 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).