From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Mark Brown <broonie@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>
Subject: Re: [PATCH] ASoC: samsung: Remove unselectable smdk_wm8580pcm
Date: Wed, 9 Nov 2016 22:43:50 +0200 [thread overview]
Message-ID: <20161109204350.GA16290@kozik-lap> (raw)
In-Reply-To: <1478717110-18108-1-git-send-email-lars@metafoo.de>
On Wed, Nov 09, 2016 at 07:45:10PM +0100, Lars-Peter Clausen wrote:
> The SND_SOC_SMDK_WM8580_PCM Kconfig entry depends on either MACH_SMDKV210
> or MACH_SMDKC110. Both of which were removed in commit 28c8331d386a ("ARM:
> S5PV210: Remove support for board files") over two years ago. The driver
> has been unselectable ever since.
The boards were converted to DT-only thus there are no MACH_xxx
symbols. They are still supporter... but actually it does not matter
because the machine_is_smdkc110() calls will return false on DT-based
platform.
I see there is even more to cleanup of these old MACH symbols.
Anyway:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-11-09 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161109184522epcas3p1b6a61f251627a16ba38c4a5c68a357c8@epcas3p1.samsung.com>
2016-11-09 18:45 ` [PATCH] ASoC: samsung: Remove unselectable smdk_wm8580pcm Lars-Peter Clausen
2016-11-09 20:43 ` Krzysztof Kozlowski [this message]
2016-11-10 9:31 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161109204350.GA16290@kozik-lap \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).