From mboxrd@z Thu Jan  1 00:00:00 1970
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] crec: Add option to specify codec ID
Date: Wed, 16 Nov 2016 13:48:35 +0000
Message-ID: <20161116134835.GW1575@localhost.localdomain>
References: <1479296649-18278-1-git-send-email-rf@opensource.wolfsonmicro.com>
 <20161116130508.GZ3000@localhost>
 <1479301675.18450.18.camel@rf-debian.wolfsonmicro.main>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com
 [67.231.152.168])
 by alsa0.perex.cz (Postfix) with ESMTP id B48FB26664F
 for <alsa-devel@alsa-project.org>; Wed, 16 Nov 2016 14:48:24 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1479301675.18450.18.camel@rf-debian.wolfsonmicro.main>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: Vinod Koul <vinod.koul@intel.com>, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
List-Id: alsa-devel@alsa-project.org

On Wed, Nov 16, 2016 at 01:07:55PM +0000, Richard Fitzgerald wrote:
> On Wed, 2016-11-16 at 18:35 +0530, Vinod Koul wrote:
> > On Wed, Nov 16, 2016 at 11:44:09AM +0000, Richard Fitzgerald wrote:
> > > This patch adds a -I command line option to set the codec ID,
> > > either from a defined set of string values or as a number.
> > 
> > Can you explain why you want to add this? The utility cant really record a
> > mp3 file!
> > 
> > 
> 
> You need to be able to pass a codec ID that the driver supports, and to
> indicate which codec you're trying to use. It's not useful to only be
> able to open the "PCM" codec. It doesn't really matter whether crec
> understands the content of the data, we're just pulling raw data, most
> likely for test/debug.
> 
> The wm_adsp driver on Wolfson/Cirrus codecs uses the new BESPOKE stream
> ID so we need a way to pass that. And we'd also need it for any drivers
> that had streams using other codec IDs.
> 

Is the objection here not that crec is wrapping the data with
a WAV file? Should we perhaps just expand this so that if you
request a different format it uses the raw data mode that it uses
when you let the output go to stdout.

Thanks,
Charles