From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>, Simon <horms@verge.net.au>
Subject: Re: [PATCH 05/19] ASoC: wm8510: Convert to module_i2c/spi_driver()
Date: Thu, 17 Nov 2016 09:33:33 +0000 [thread overview]
Message-ID: <20161117093333.GZ1575@localhost.localdomain> (raw)
In-Reply-To: <87h9776jxx.wl%kuninori.morimoto.gx@renesas.com>
On Thu, Nov 17, 2016 at 12:16:06AM +0000, Kuninori Morimoto wrote:
>
> Hi Charles
>
> Thank you for your feedback
>
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > >
> > > Let's use module_i2c/spi_driver()
> > >
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> >
> > Yeah I think from here on in the series these have the I2C/SPI
> > issues Lars mentions.
>
> I can create xx-i2c.c xx-spi.c as Lars mentioned.
> Do you think it is nice ? or do nothing for these drivers is nice ?
> If it is "nice to have", I can try it, please let me know.
>
> I will fixup I2C side patches only, and post these as v2 patch.
> I will post I2C/SPI patches if these were "nice to have"
Creating the seperate I2C/SPI files would indeed be the best way
to go, however, personally I would be inclined to leave them
alone. They are mostly legacy parts, I won't have hardware to
test almost all of them and there is no pressing need to update
them at this time.
Thanks,
Charles
next prev parent reply other threads:[~2016-11-17 9:33 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-15 5:08 [PATCH 00/19] ASoC: Convert to module_i2c/spi_driver() Kuninori Morimoto
2016-11-15 5:09 ` [PATCH 01/19] ASoC: uda1380: Convert to module_i2c_driver() Kuninori Morimoto
2016-11-15 6:21 ` Takashi Iwai
2016-11-15 6:42 ` Kuninori Morimoto
2016-11-15 7:30 ` Takashi Iwai
2016-11-15 12:08 ` Lars-Peter Clausen
2016-11-16 18:01 ` Mark Brown
2016-11-17 0:18 ` Kuninori Morimoto
2016-11-21 19:20 ` Applied "ASoC: uda1380: Remove #if IS_ENABLED(CONFIG_I2C)" to the asoc tree Mark Brown
2016-11-15 5:09 ` [PATCH 02/19] ASoC: wm9081: Convert to module_i2c_driver() Kuninori Morimoto
2016-11-16 9:38 ` [alsa-devel] " Charles Keepax
2016-11-16 9:39 ` Charles Keepax
2016-11-17 0:43 ` Kuninori Morimoto
2016-11-21 19:20 ` Applied "ASoC: wm9081: Remove #if IS_ENABLED(CONFIG_I2C)" to the asoc tree Mark Brown
2016-11-15 5:09 ` [PATCH 03/19] ASoC: wm8580: Convert to module_i2c_driver() Kuninori Morimoto
2016-11-16 9:41 ` Charles Keepax
2016-11-17 0:10 ` Kuninori Morimoto
2016-11-15 5:10 ` [PATCH 04/19] ASoC: wm8523: " Kuninori Morimoto
2016-11-16 9:42 ` Charles Keepax
2016-11-21 19:20 ` Applied "ASoC: wm8523: Remove #if IS_ENABLED(CONFIG_I2C)" to the asoc tree Mark Brown
2016-11-15 5:10 ` [PATCH 05/19] ASoC: wm8510: Convert to module_i2c/spi_driver() Kuninori Morimoto
2016-11-15 8:33 ` Lars-Peter Clausen
2016-11-15 8:49 ` Kuninori Morimoto
2016-11-15 17:21 ` kbuild test robot
2016-11-16 9:44 ` Charles Keepax
2016-11-17 0:16 ` Kuninori Morimoto
2016-11-17 9:33 ` Charles Keepax [this message]
2016-11-17 9:51 ` Kuninori Morimoto
2016-11-15 5:10 ` [PATCH 06/19] ASoC: wm8995: " Kuninori Morimoto
2016-11-15 18:05 ` kbuild test robot
2016-11-15 5:11 ` [PATCH 07/19] ASoC: wm8988: " Kuninori Morimoto
2016-11-15 5:11 ` [PATCH 08/19] ASoC: wm8985: " Kuninori Morimoto
2016-11-15 17:40 ` kbuild test robot
2016-11-15 5:11 ` [PATCH 09/19] ASoC: wm8983: " Kuninori Morimoto
2016-11-15 5:12 ` [PATCH 10/19] ASoC: wm8900: " Kuninori Morimoto
2016-11-15 5:12 ` [PATCH 11/19] ASoC: wm8776: " Kuninori Morimoto
2016-11-15 17:51 ` kbuild test robot
2016-11-15 5:12 ` [PATCH 12/19] ASoC: wm8753: " Kuninori Morimoto
2016-11-15 17:35 ` kbuild test robot
2016-11-15 5:13 ` [PATCH 13/19] ASoC: wm8750: " Kuninori Morimoto
2016-11-15 5:13 ` [PATCH 14/19] ASoC: wm8741: " Kuninori Morimoto
2016-11-15 17:51 ` kbuild test robot
2016-11-15 5:13 ` [PATCH 15/19] ASoC: wm8731: " Kuninori Morimoto
2016-11-15 18:07 ` kbuild test robot
2016-11-15 5:13 ` [PATCH 16/19] ASoC: wm8737: " Kuninori Morimoto
2016-11-15 5:14 ` [PATCH 17/19] ASoC: wm8728: " Kuninori Morimoto
2016-11-15 5:14 ` [PATCH 18/19] ASoC: wm8711: " Kuninori Morimoto
2016-11-15 5:14 ` [PATCH 19/19] ASoC: da7210: " Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161117093333.GZ1575@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).