From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [patch] ASoC: sh: dma-sh7760: fix a debug printf Date: Thu, 17 Nov 2016 16:55:38 +0300 Message-ID: <20161117135537.GV28558@mwanda> References: <20161117110046.GC32143@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) by alsa0.perex.cz (Postfix) with ESMTP id 6630B2665B0 for ; Thu, 17 Nov 2016 14:56:03 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: bojan prtvar Cc: alsa-devel@alsa-project.org, Manuel Lauss , kernel-janitors@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown List-Id: alsa-devel@alsa-project.org On Thu, Nov 17, 2016 at 02:31:06PM +0100, bojan prtvar wrote: > Hi, > > On Thu, Nov 17, 2016 at 12:00 PM, Dan Carpenter > wrote: > > > - pr_debug("PCM data: addr 0x%08ulx len %d\n", > > + pr_debug("PCM data: addr 0x%08lx len %d\n", > > (u32)runtime->dma_addr, runtime->dma_bytes); > > While there, why not using %pad as suggested by > Documentation/printk-formats.txt? Oh crap. I never even compiled this stuff... I'm really sorry it's been a while since I screwed up like this. Sorry about this. That sounds like a good idea but I don't have a cross compiler set up so I'm going to leave it alone for now. regards, dan carpenter