alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
	alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
	Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] crec: Add option to specify codec ID
Date: Fri, 18 Nov 2016 16:17:37 +0000	[thread overview]
Message-ID: <20161118161737.GB1575@localhost.localdomain> (raw)
In-Reply-To: <fe7dcb27-fda9-47bc-7766-2896e1954218@linux.intel.com>

On Fri, Nov 18, 2016 at 08:39:38AM -0600, Pierre-Louis Bossart wrote:
> 
> >>If you're debugging you may not care about the file format, you're
> >>actually interested in the raw data you get from the codec so dumping
> >>the output to a raw file would be useful even if you can't load that
> >>file into a music player.
> >
> >While I agree with you on this, am worried that adding codecs may make
> >people think that we can record mp3 file for exmaple, which is not the case.
> >
> >I think we can add pcm and bespoke as formats supported and allow any format to
> >be dumped to stdio. That way it is pretty clear to people ...
> 
> Crec as is it is pretty useless with PCM only...If we added the profile
> selection and things like bitrate information it'd be straightforward to
> support elementary bitstreams like MP3 or AAC ADTS, you just dump the data
> to a file. Things that require a header or MP4 integration would require
> additional libraries, this is no longer 'tiny'.

What about this as a suggestion, if we remove the code that adds
the WAV header. Then all the output from crecord is raw data and
the addition of any headers or additional wrapping is up to the
user. That keeps crecord 'tiny' and allows us to support all the
formats in a consistent way so no one gets confused.

We haven't actually used the WAV header stuff since the very
early versions of our firmware that didn't use compression on the
stream and actually did output PCM data and I don't think anyone
else has ever used the compressed interface for PCM.

Thanks,
Charles

  reply	other threads:[~2016-11-18 16:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-16 11:44 [PATCH] crec: Add option to specify codec ID Richard Fitzgerald
2016-11-16 13:05 ` Vinod Koul
2016-11-16 13:07   ` Richard Fitzgerald
2016-11-16 13:48     ` Charles Keepax
2016-11-16 14:53       ` Richard Fitzgerald
2016-11-18  3:53         ` Vinod Koul
2016-11-18 10:11           ` Richard Fitzgerald
2016-11-18 10:29             ` Vinod Koul
2016-11-18 14:39               ` Pierre-Louis Bossart
2016-11-18 16:17                 ` Charles Keepax [this message]
2016-11-23  3:41                   ` Vinod Koul
2016-11-23 10:21                     ` Richard Fitzgerald
2016-11-23 10:38                       ` Vinod Koul
2016-11-27 17:52                         ` Pierre-Louis Bossart
2016-11-28  9:47                           ` Richard Fitzgerald
2016-11-28 15:54                             ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161118161737.GB1575@localhost.localdomain \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rf@opensource.wolfsonmicro.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).