From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
intel-gfx@lists.freedesktop.org, broonie@kernel.org,
rakesh.a.ughreja@intel.com
Subject: Re: [alsa-devel] [RFC PATCH v3 1/7] drm/i915: setup bridge for HDMI LPE audio driver
Date: Mon, 28 Nov 2016 15:43:07 +0200 [thread overview]
Message-ID: <20161128134307.GY31595@intel.com> (raw)
In-Reply-To: <86def769-e4ea-199d-59c9-168f8eab7795@linux.intel.com>
On Sun, Nov 27, 2016 at 12:20:30PM -0600, Pierre-Louis Bossart wrote:
> On 11/24/16 7:31 AM, Ville Syrjälä wrote:
> >> +static void lpe_audio_irq_unmask(struct irq_data *d)
> >> +{
> >> + struct drm_device *dev = d->chip_data;
> >> + struct drm_i915_private *dev_priv = to_i915(dev);
> >> + unsigned long irqflags;
> >> + u32 val = (I915_LPE_PIPE_A_INTERRUPT |
> >> + I915_LPE_PIPE_B_INTERRUPT |
> >> + I915_LPE_PIPE_C_INTERRUPT);
> > No pipe C on vlv.
>
> Yes but does it hurt to set this bit? If the hardware is not present
> then there is no side effect, is there?
I'm too lazy to check if the bit is already taken.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-11-28 13:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161124235548.16440-1-jerome.anand@intel.com>
[not found] ` <20161124235548.16440-2-jerome.anand@intel.com>
2016-11-24 13:31 ` [RFC PATCH v3 1/7] drm/i915: setup bridge for HDMI LPE audio driver Ville Syrjälä
2016-11-25 5:42 ` Anand, Jerome
2016-11-25 10:18 ` Ville Syrjälä
2016-11-25 10:52 ` Jani Nikula
2016-11-28 1:50 ` Anand, Jerome
2016-11-28 8:06 ` Jani Nikula
2016-11-27 18:20 ` [alsa-devel] " Pierre-Louis Bossart
2016-11-28 13:43 ` Ville Syrjälä [this message]
[not found] ` <20161124235548.16440-3-jerome.anand@intel.com>
2016-11-24 13:32 ` [RFC PATCH v3 2/7] drm/i915: Add support for audio driver notifications Ville Syrjälä
2016-11-25 5:51 ` Anand, Jerome
2016-11-28 14:00 ` Ville Syrjälä
2016-11-28 16:50 ` Anand, Jerome
2016-11-28 17:01 ` Ville Syrjälä
2016-11-28 19:13 ` Pierre-Louis Bossart
2016-11-28 19:30 ` Ville Syrjälä
2016-11-28 21:56 ` Pierre-Louis Bossart
2016-11-29 8:27 ` Takashi Iwai
2016-11-29 16:22 ` Anand, Jerome
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128134307.GY31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rakesh.a.ughreja@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).