From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [PATCH] ASoC: intel: Replace kthread with work
Date: Tue, 29 Nov 2016 19:13:41 +0530 [thread overview]
Message-ID: <20161129134340.GS6408@localhost> (raw)
In-Reply-To: <20161128155236.GF6408@localhost>
On Mon, Nov 28, 2016 at 09:22:36PM +0530, Vinod Koul wrote:
> On Mon, Nov 28, 2016 at 04:32:19PM +0100, Takashi Iwai wrote:
> > The usage pattern of kthread worker in Intel SST drivers can be
> > replaced gracefully with the normal workqueue, which is more light-
> > weight and easier to manage in general. Let's do it.
> >
> > While in the replacement, move the schedule_work() call inside the
> > spinlock for excluding the race, too.
> >
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > ---
> >
> > Vinod, I tested this only lightly, so it'd be helpful if the patch is
> > checked on the affected devices before merging.
>
> We had apatch done last week internally for this, but this one is fine too.
>
> I will get it verfied on SKL tomorrow and get back
Hi Takashi,
Works fine :)
Acked-by: Vinod Koul <vinod.koul@intel.com>
Tested-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
Thanks
--
~Vinod
next prev parent reply other threads:[~2016-11-29 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 15:32 [PATCH] ASoC: intel: Replace kthread with work Takashi Iwai
2016-11-28 15:52 ` Vinod Koul
2016-11-29 13:43 ` Vinod Koul [this message]
2016-11-30 18:07 ` Applied "ASoC: intel: Replace kthread with work" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129134340.GS6408@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox