* [PATCH] ALSA: usb-audio: add implicit fb quirk for Axe-Fx II
@ 2016-12-08 6:36 Alberto Aguirre
2016-12-09 10:19 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Alberto Aguirre @ 2016-12-08 6:36 UTC (permalink / raw)
To: alsa-devel; +Cc: Alberto Aguirre
The Axe-Fx II implicit feedback end point and the data sync endpoint
are in different interface descriptors. Add quirk to ensure a sync
endpoint is properly configured.
Signed-off-by: Alberto Aguirre <albaguirre@gmail.com>
---
sound/usb/pcm.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index 44d178e..0fe2d56 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -348,6 +348,16 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs,
alts = &iface->altsetting[1];
goto add_sync_ep;
+ case USB_ID(0x2466, 0x8003):
+ ep = 0x86;
+ iface = usb_ifnum_to_if(dev, 2);
+
+ if (!iface || iface->num_altsetting == 0)
+ return -EINVAL;
+
+ alts = &iface->altsetting[1];
+ goto add_sync_ep;
+
}
if (attr == USB_ENDPOINT_SYNC_ASYNC &&
altsd->bInterfaceClass == USB_CLASS_VENDOR_SPEC &&
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ALSA: usb-audio: add implicit fb quirk for Axe-Fx II
@ 2016-12-08 21:38 Alberto Aguirre
0 siblings, 0 replies; 3+ messages in thread
From: Alberto Aguirre @ 2016-12-08 21:38 UTC (permalink / raw)
To: alsa-devel; +Cc: Alberto Aguirre
The Axe-Fx II implicit feedback end point and the data sink endpoint
are in different interface descriptors. Add quirk to ensure a sync
endpoint is properly configured.
Signed-off-by: Alberto Aguirre <albaguirre@gmail.com>
---
sound/usb/pcm.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
index 44d178e..584f2a6 100644
--- a/sound/usb/pcm.c
+++ b/sound/usb/pcm.c
@@ -348,6 +348,16 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs,
alts = &iface->altsetting[1];
goto add_sync_ep;
+ case USB_ID(0x2466, 0x8003): /* Fractal Audio Axe-Fx II */
+ ep = 0x86;
+ iface = usb_ifnum_to_if(dev, 2);
+
+ if (!iface || iface->num_altsetting == 0)
+ return -EINVAL;
+
+ alts = &iface->altsetting[1];
+ goto add_sync_ep;
+
}
if (attr == USB_ENDPOINT_SYNC_ASYNC &&
altsd->bInterfaceClass == USB_CLASS_VENDOR_SPEC &&
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ALSA: usb-audio: add implicit fb quirk for Axe-Fx II
2016-12-08 6:36 [PATCH] ALSA: usb-audio: add implicit fb quirk for Axe-Fx II Alberto Aguirre
@ 2016-12-09 10:19 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2016-12-09 10:19 UTC (permalink / raw)
To: Alberto Aguirre; +Cc: alsa-devel
On Thu, 08 Dec 2016 07:36:48 +0100,
Alberto Aguirre wrote:
>
> The Axe-Fx II implicit feedback end point and the data sync endpoint
> are in different interface descriptors. Add quirk to ensure a sync
> endpoint is properly configured.
>
> Signed-off-by: Alberto Aguirre <albaguirre@gmail.com>
Applied, thanks.
Takashi
> ---
> sound/usb/pcm.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> index 44d178e..0fe2d56 100644
> --- a/sound/usb/pcm.c
> +++ b/sound/usb/pcm.c
> @@ -348,6 +348,16 @@ static int set_sync_ep_implicit_fb_quirk(struct snd_usb_substream *subs,
>
> alts = &iface->altsetting[1];
> goto add_sync_ep;
> + case USB_ID(0x2466, 0x8003):
> + ep = 0x86;
> + iface = usb_ifnum_to_if(dev, 2);
> +
> + if (!iface || iface->num_altsetting == 0)
> + return -EINVAL;
> +
> + alts = &iface->altsetting[1];
> + goto add_sync_ep;
> +
> }
> if (attr == USB_ENDPOINT_SYNC_ASYNC &&
> altsd->bInterfaceClass == USB_CLASS_VENDOR_SPEC &&
> --
> 2.9.3
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-09 10:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-08 6:36 [PATCH] ALSA: usb-audio: add implicit fb quirk for Axe-Fx II Alberto Aguirre
2016-12-09 10:19 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2016-12-08 21:38 Alberto Aguirre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).