From: Vinod Koul <vinod.koul@intel.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: liam.r.girdwood@linux.intel.com,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 09/14] ASoC: max9867: remove unused ‘ret’
Date: Fri, 9 Dec 2016 12:26:13 +0530 [thread overview]
Message-ID: <20161209065613.GI6408@localhost> (raw)
In-Reply-To: <CAOMZO5C5WHW+a4F5gTV2T5xw3pMjrvkr4JsfS7rxU7d2=-tbKA@mail.gmail.com>
On Thu, Dec 08, 2016 at 08:48:49PM -0200, Fabio Estevam wrote:
> On Thu, Dec 8, 2016 at 3:31 PM, Vinod Koul <vinod.koul@intel.com> wrote:
>
> > - ret = regmap_write(max9867->regmap, MAX9867_IFC1A, iface1A);
> > - ret = regmap_write(max9867->regmap, MAX9867_IFC1B, iface1B);
> > + regmap_write(max9867->regmap, MAX9867_IFC1A, iface1A);
> > + regmap_write(max9867->regmap, MAX9867_IFC1B, iface1B);
>
> What about doing like this instead?
>
> ret = regmap_write(max9867->regmap, MAX9867_IFC1A, iface1A);
> if (ret)
> return ret;
>
> ret = regmap_write(max9867->regmap, MAX9867_IFC1B, iface1B);
> if (ret)
> return ret;
yeah we can, but I didn't want to add/remove anything from this code, so
skipped the return which has same effect as previous code.
Btw should regmap_write() return be strictly checked or not?
Thanks
--
~Vinod
next prev parent reply other threads:[~2016-12-09 6:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 17:31 [PATCH 00/14] ASoC: Compile fixes with W=1 Vinod Koul
2016-12-08 17:31 ` [PATCH 01/14] ASoC: Intel: Skylake: remove unused 'ret' Vinod Koul
2016-12-15 12:21 ` Applied "ASoC: Intel: Skylake: remove unused 'ret'" to the asoc tree Mark Brown
2016-12-08 17:31 ` [PATCH 02/14] ASoC: Intel: sst: remove unused 'msg_high' Vinod Koul
2016-12-15 12:21 ` Applied "ASoC: Intel: sst: remove unused 'msg_high'" to the asoc tree Mark Brown
2016-12-08 17:31 ` [PATCH 03/14] ASoC: Intel: sst: remove unused 'ops' Vinod Koul
2016-12-15 12:21 ` Applied "ASoC: Intel: sst: remove unused 'ops'" to the asoc tree Mark Brown
2016-12-08 17:31 ` [PATCH 04/14] ASoC: topology: remove unused 'err' Vinod Koul
2016-12-15 12:21 ` Applied "ASoC: topology: remove unused 'err'" to the asoc tree Mark Brown
2016-12-08 17:31 ` [PATCH 05/14] ASoC: hdac_hdmi: remove unused 'dai_map' Vinod Koul
2016-12-15 12:21 ` Applied "ASoC: hdac_hdmi: remove unused 'dai_map'" to the asoc tree Mark Brown
2016-12-08 17:31 ` [PATCH 06/14] ASoC: max98090: remove superflous check for 'micbias' Vinod Koul
2016-12-15 12:21 ` Applied "ASoC: max98090: remove superflous check for 'micbias'" to the asoc tree Mark Brown
2016-12-08 17:31 ` [PATCH 07/14] ASoC: AMD: remove unused ‘dma_buffer’ Vinod Koul
2016-12-08 17:31 ` [PATCH 08/14] ASoC: adau17x1: remove unused ‘ret’ Vinod Koul
2016-12-08 17:31 ` [PATCH 09/14] ASoC: max9867: " Vinod Koul
2016-12-08 22:48 ` Fabio Estevam
2016-12-09 6:56 ` Vinod Koul [this message]
2016-12-15 11:22 ` Mark Brown
2016-12-08 17:31 ` [PATCH 10/14] ASoC: pcm3168a: remove unused ‘format’ Vinod Koul
2016-12-08 17:31 ` [PATCH 11/14] ASoC: img: " Vinod Koul
2016-12-08 17:31 ` [PATCH 12/14] ASoC: Intel: sst: remove unused ‘ret_val’ Vinod Koul
2016-12-08 17:31 ` [PATCH 13/14] ASoC: samsung: smdk_wm8580: remove unused ‘bfs’ Vinod Koul
2016-12-08 17:31 ` [PATCH 14/14] ASoC: zx296702-i2s: remove unused ‘format’ Vinod Koul
2016-12-09 2:47 ` Jun Nie
2016-12-15 11:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161209065613.GI6408@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox