From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org, jarkko.nikula@bitmer.com, jsarha@ti.com
Subject: [PATCH 2/3] ASoC: tlv320aic3x: Add delay after power on and register sync
Date: Fri, 23 Dec 2016 11:21:11 +0200 [thread overview]
Message-ID: <20161223092112.7992-3-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <20161223092112.7992-1-peter.ujfalusi@ti.com>
When the codec is powered on, it's registers are in reset state as the
power off will do a soft reset of the codec.
After the register sync we need to add delay to remove the pop-noise on
stream start.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
sound/soc/codecs/tlv320aic3x.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index 7b6924e19021..bc220f83dd1f 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -1393,6 +1393,12 @@ static int aic3x_set_power(struct snd_soc_codec *codec, int power)
snd_soc_write(codec, AIC3X_PLL_PROGC_REG, pll_c);
snd_soc_write(codec, AIC3X_PLL_PROGD_REG, pll_d);
}
+
+ /*
+ * Delay is needed to reduce pop-noise after syncing back the
+ * registers
+ */
+ mdelay(50);
} else {
/*
* Do soft reset to this codec instance in order to clear
--
2.11.0
next prev parent reply other threads:[~2016-12-23 9:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 9:21 [PATCH 0/3] ASoC: tlv320aic3x: Pop noise reductions Peter Ujfalusi
2016-12-23 9:21 ` [PATCH 1/3] ASoC: tlv320aic3x: Mark the RESET register as volatile Peter Ujfalusi
2016-12-23 18:27 ` Jarkko Nikula
2017-01-02 11:51 ` Peter Ujfalusi
2016-12-31 19:19 ` Applied "ASoC: tlv320aic3x: Mark the RESET register as volatile" to the asoc tree Mark Brown
2016-12-23 9:21 ` Peter Ujfalusi [this message]
2016-12-31 19:19 ` Applied "ASoC: tlv320aic3x: Add delay after power on and register sync" " Mark Brown
2016-12-23 9:21 ` [PATCH 3/3] ASoC: tlv320aic3x: Add controls for selecting HP power down modes Peter Ujfalusi
2016-12-23 18:47 ` Jarkko Nikula
2016-12-31 18:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161223092112.7992-3-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=jsarha@ti.com \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox