Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ioan-Adrian Ratiu <adi@adirat.com>
To: tiwai@suse.com, perex@perex.cz, o-takashi@sakamocchi.jp
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: [PATCH v2 0/2] ALSA: Fix usb-audio races
Date: Mon,  2 Jan 2017 17:50:29 +0200	[thread overview]
Message-ID: <20170102155031.3638-1-adi@adirat.com> (raw)

Many thanks to Takashi Iwai & Sakamoto for their awesome feedback.

Changes since v1:
    * Rebased my fix on top of tiwai's revert and integrated the changes
    from the original fix into this.
    * Dropped the stop_endpoints() call inside snd_usb_pcm_prepare() and
    kept the previously existing snd_usb_endpoint_sync_pending_stop() call.
    * Retained the deactivate_urbs() call in snd_usb_pcm_prepare(), I only
    removed the can_sleep logic.
    * Split the EP_FLAG_RUNNING check in a separate commit to keep the log
    clean since this is not part of the race fix.

Ioan-Adrian Ratiu (2):
  ALSA: usb-audio: Fix irq/process data synchronization
  ALSA: usb-audio: test EP_FLAG_RUNNING at urb completion

 sound/usb/endpoint.c | 20 ++++++++++----------
 sound/usb/endpoint.h |  2 +-
 sound/usb/pcm.c      | 10 +++++-----
 3 files changed, 16 insertions(+), 16 deletions(-)

-- 
2.11.0

             reply	other threads:[~2017-01-02 15:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 15:50 Ioan-Adrian Ratiu [this message]
2017-01-02 15:50 ` [PATCH v2 1/2] ALSA: usb-audio: Fix irq/process data synchronization Ioan-Adrian Ratiu
2017-01-04  6:28   ` Takashi Iwai
2017-01-04  9:15     ` Ioan-Adrian Ratiu
2017-01-02 15:50 ` [PATCH v2 2/2] ALSA: usb-audio: test EP_FLAG_RUNNING at urb completion Ioan-Adrian Ratiu
2017-01-03  7:30 ` [PATCH v2 0/2] ALSA: Fix usb-audio races Ioan-Adrian Ratiu
2017-01-03  8:47   ` Ioan-Adrian Ratiu
2017-01-03  9:15     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170102155031.3638-1-adi@adirat.com \
    --to=adi@adirat.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o-takashi@sakamocchi.jp \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox